Skip to content

md: bitmap grow fixes

Su Yue linux-raid 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 16 repliesIn review
  2. v13 patches 6 repliesSuperseded

Changes in v2 from the cover letter

Add a dummy bitmap operations per Kuai's suggestion.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5md/md-bitmap: call md_bitmap_create,destroy in location_storedrivers/md/md-bitmap.c drivers/md/md.c drivers/md/md.h+12 -56 replies
2/5md/md-bitmap: add an extra sysfs argument to md_bitmap_create and destroydrivers/md/md-bitmap.c drivers/md/md.c drivers/md/md.h+23 -231 reply
3/5md/md-bitmap: add dummy bitmap ops for none to fix wrong bitmap offsetdrivers/md/md-bitmap.c drivers/md/md-bitmap.h drivers/md/md-llbitmap.c +1 more+130 -174 replies
4/5md: skip ID_BITMAP_NONE when show available bitmap typesdrivers/md/md.c+2 -02 replies
5/5md/md-bitmap: remove member group from bitmap_operationsdrivers/md/md-bitmap.h drivers/md/md-llbitmap.c+0 -30 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchXiao Ni
1/5
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] md: bitmap grow fixes

Hi, This v2 series is to fixes bugs exposed by mdadm/clustermd-autotest. The bugs are not cluster md only but also bitmap related.

The series based on v7.0-rc7 passes tests with mdadm v4.6 without regression.

v2:
Add a dummy bitmap operations per Kuai's suggestion.

To Yu Kuai:
A NULL group can't used for internal_bitmap_group since
the entries from internal_bitmap_attrs should be under bitmap.
So instead of sysfs_create_groups(), sysfs_create_group() and sysfs_merge_group() are still needed /sigh.

Su Yue (5):
md/md-bitmap: call md_bitmap_create,destroy in location_store md/md-bitmap: add an extra sysfs argument to md_bitmap_create and
destroy
md/md-bitmap: add dummy bitmap ops for none to fix wrong bitmap offset
md: skip ID_BITMAP_NONE when show available bitmap types md/md-bitmap: remove member group from bitmap_operations

 drivers/md/md-bitmap.c   | 121 ++++++++++++++++++++++++++++++++++++---
 drivers/md/md-bitmap.h   |   3 +-
 drivers/md/md-llbitmap.c |  13 ++++-
 drivers/md/md.c          |  55 +++++++++---------
 drivers/md/md.h          |   2 +
 5 files changed, 155 insertions(+), 39 deletions(-)
Signature · 1 line
2.53.0