fs: Move metadata bh tracking from address_space
Status from this message: Applied to the vfs-7.1.bh.metadata branch of the vfs/vfs.git tree.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v3 from the cover letter
* Added Reviewed-by tags from Christoph
* Dropped the patch unifying fsync implementation in fs/libfs.c and fs/buffer.c
* Put fsync locking change into a separate commit
* Reordered series to place all fsync path modifications close together
* Improved some changelogs
* Renamed some functions based on Christoph's feedback
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/42 | ext4: Use inode_has_buffers()fs/ fs/ | +2 | 0 replies | |
| 2/42 | gfs2: Don't zero i_private_datafs/ | +0 | 0 replies | |
| 3/42 | ntfs3: Drop pointless sync_mapping_buffers() and invalidate_inode_buffers() callsfs/ fs/ | +0 | 0 replies | |
| 4/42 | ocfs2: Drop pointless sync_mapping_buffers() callsfs/ fs/ | +0 | 0 replies | |
| 5/42 | bdev: Drop pointless invalidate_inode_buffers() callblock/ | +0 | 1 reply | |
| 6/42 | ufs: Drop pointless invalidate_mapping_buffers() callfs/ | +0 | 0 replies | |
| 7/42 | exfat: Drop pointless invalidate_inode_buffers() callfs/ | +0 | 0 replies | |
| 8/42 | fs: Remove inode lock from __generic_file_fsync()fs/ | +0 | 1 reply | |
| 9/42 | udf: Switch to generic_buffers_fsync()fs/ fs/ | +2 | 0 replies | |
| 10/42 | minix: Switch to generic_buffers_fsync()fs/ fs/ | +2 | 0 replies | |
| 11/42 | bfs: Switch to generic_buffers_fsync()fs/ | +1 | 0 replies | |
| 12/42 | fat: Switch to generic_buffers_fsync_noflush()fs/ | +1 | 0 replies | |
| 13/42 | fs: Drop sync_mapping_buffers() from __generic_file_fsync()fs/ | +2 | 1 reply | |
| 14/42 | fs: Rename generic_file_fsync() to simple_fsync()fs/ fs/ fs/ +7 more | +22 | 2 replies | |
| 15/42 | fat: Sync and invalidate metadata buffers from fat_evict_inode()fs/ | +3 | 9 replies | |
| 16/42 | udf: Sync and invalidate metadata buffers from udf_evict_inode()fs/ | +2 | 0 replies | |
| 17/42 | minix: Sync and invalidate metadata buffers from minix_evict_inode()fs/ | +2 | 0 replies | |
| 18/42 | ext2: Sync and invalidate metadata buffers from ext2_evict_inode()fs/ | +2 | 0 replies | |
| 19/42 | ext4: Sync and invalidate metadata buffers from ext4_evict_inode()fs/ fs/ | +5 | 0 replies | |
| 20/42 | bfs: Sync and invalidate metadata buffers from bfs_evict_inode()fs/ | +2 | 0 replies | |
| 21/42 | affs: Sync and invalidate metadata buffers from affs_evict_inode()fs/ | +2 | 0 replies | |
| 22/42 | fs: Ignore inode metadata buffers in inode_lru_isolate()fs/ fs/ include/ | +9 | 1 reply | |
| 23/42 | fs: Stop using i_private_data for metadata bh trackingfs/ | +5 | 0 replies | |
| 24/42 | hugetlbfs: Stop using i_private_datafs/ include/ mm/ | +5 | 0 replies | |
| 25/42 | aio: Stop using i_private_data and i_private_lockfs/ | +66 | 0 replies | |
| 26/42 | fs: Remove i_private_datafs/ include/ | +0 | 0 replies | |
| 27/42 | kvm: Use private inode list instead of i_private_listvirt/ | +7 | 0 replies | |
| 28/42 | fs: Drop osync_buffers_list()fs/ | +2 | 0 replies | |
| 29/42 | fs: Fold fsync_buffers_list() into sync_mapping_buffers()fs/ | +80 | 0 replies | |
| 30/42 | fs: Move metadata bhs tracking to a separate structfs/ fs/ include/ | +74 | 0 replies | |
| 31/42 | fs: Make bhs point to mapping_metadata_bhsfs/ fs/ include/ +1 more | +20 | 0 replies | |
| 32/42 | fs: Switch inode_has_buffers() to take mapping_metadata_bhsfs/ fs/ include/ | +9 | 0 replies | |
| 33/42 | fs: Provide functions for handling mapping_metadata_bhs directlyfs/ include/ | +87 | 1 reply | |
| 34/42 | ext2: Track metadata bhs in fs-private inode partfs/ fs/ fs/ +1 more | +15 | 0 replies | |
| 35/42 | affs: Track metadata bhs in fs-private inode partfs/ fs/ fs/ +3 more | +35 | 0 replies | |
| 36/42 | bfs: Track metadata bhs in fs-private inode partfs/ fs/ fs/ | +17 | 0 replies | |
| 37/42 | fat: Track metadata bhs in fs-private inode partfs/ fs/ fs/ +4 more | +34 | 0 replies | |
| 38/42 | udf: Track metadata bhs in fs-private inode partfs/ fs/ fs/ +6 more | +25 | 0 replies | |
| 39/42 | minix: Track metadata bhs in fs-private inode partfs/ fs/ fs/ +2 more | +24 | 0 replies | |
| 40/42 | ext4: Track metadata bhs in fs-private inode partfs/ fs/ fs/ +2 more | +10 | 0 replies | |
| 41/42 | fs: Drop mapping_metadata_bhs from address spacefs/ include/ include/ | +0 | 1 reply | |
| 42/42 | fs: Drop i_private_list from address_spacefs/ include/ | +0 | 1 reply |
Reviews trailers per patch
20 of 42 patches have a Reviewed-by or Acked-by.
| Patch | Andreas Gruenbacher | Theodore Ts'o | Christoph Hellwig |
|---|---|---|---|
| 1/42 | A-b | ||
| 2/42 | R-b | ||
| 3/42 | |||
| 4/42 | |||
| 5/42 | R-b | ||
| 6/42 | |||
| 7/42 | |||
| 8/42 | R-b | ||
| 9/42 | |||
| 10/42 | |||
| 11/42 | |||
| 12/42 | |||
| 13/42 | R-b | ||
| 14/42 | |||
| 15/42 | |||
| 16/42 | |||
| 17/42 | |||
| 18/42 | |||
| 19/42 | A-b | ||
| 20/42 | |||
| 21/42 | |||
| 22/42 | R-b | ||
| 23/42 | R-b | ||
| 24/42 | R-b | ||
| 25/42 | R-b | ||
| 26/42 | R-b | ||
| 27/42 | R-b | ||
| 28/42 | R-b | ||
| 29/42 | R-b | ||
| 30/42 | R-b | ||
| 31/42 | R-b | ||
| 32/42 | R-b | ||
| 33/42 | R-b | ||
| 34/42 | |||
| 35/42 | |||
| 36/42 | |||
| 37/42 | |||
| 38/42 | |||
| 39/42 | |||
| 40/42 | |||
| 41/42 | R-b | ||
| 42/42 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/42] fs: Move metadata bh tracking from address_space
Hello,
here is a next revision of the patchset cleaning up buffer head metadata tracking and use of address_space's private_list and private_lock. Functionally this should be identical to v2, most of the changes were in improving changelogs, patch ordering, function names, etc. The patches have survived some testing with fstests and ltp however I didn't test AFFS and KVM guest_memfd changes so a help with testing those would be very welcome. Thanks.
Changes since v2:
* Added Reviewed-by tags from Christoph
* Dropped the patch unifying fsync implementation in fs/libfs.c and fs/buffer.c
* Put fsync locking change into a separate commit
* Reordered series to place all fsync path modifications close together
* Improved some changelogs
* Renamed some functions based on Christoph's feedback
Changes since v1:
* Fixed hugetlbfs handling of root directory
* Reworked mapping_metadata_bhs handling functions to get the tracking structure as an argument so we now don't need iops method to fetch the struct from the inode
* Reordered patches into more sensible order
* Added patch to merge two mostly duplicate generic fsync implementations
* Added Reviewed-by tags
* Couple more minor changes that were requested during review
Original cover letter:
this patch series cleans up the mess that has accumulated over the years in metadata buffer_head tracking for inodes, moves the tracking into dedicated structure in filesystem-private part of the inode (so that we don't use private_list, private_data, and private_lock in struct address_space), and also moves couple other users of private_data and private_list so these are removed from struct address_space saving 3 longs in struct inode for 99% of inodes. I would like to get rid of private_lock in struct address_space as well however the locking changes for buffer_heads are non-trivial there and the patch series is long enough as is. So let's leave that for another time.
block/bdev.c | 1 fs/affs/affs.h | 2 fs/affs/dir.c | 1 fs/affs/file.c | 1 fs/affs/inode.c | 2 fs/affs/super.c | 6 fs/affs/symlink.c | 1 fs/aio.c | 78 +++++++- fs/bfs/bfs.h | 2 fs/bfs/dir.c | 1 fs/bfs/file.c | 4 fs/bfs/inode.c | 9 + fs/buffer.c | 387 +++++++++++++++++--------------------------- fs/ext2/ext2.h | 2 fs/ext2/file.c | 1 fs/ext2/inode.c | 3 fs/ext2/namei.c | 2 fs/ext2/super.c | 6 fs/ext2/symlink.c | 2 fs/ext4/ext4.h | 4 fs/ext4/file.c | 1 fs/ext4/inode.c | 9 - fs/ext4/namei.c | 2 fs/ext4/super.c | 9 - fs/ext4/symlink.c | 3 fs/fat/fat.h | 2 fs/fat/file.c | 1 fs/fat/inode.c | 16 + fs/fat/namei_msdos.c | 1 fs/fat/namei_vfat.c | 1 fs/gfs2/glock.c | 1 fs/hugetlbfs/inode.c | 10 - fs/inode.c | 24 +- fs/minix/file.c | 1 fs/minix/inode.c | 10 + fs/minix/minix.h | 2 fs/minix/namei.c | 1 fs/ntfs3/file.c | 3 fs/ocfs2/dlmglue.c | 1 fs/ocfs2/namei.c | 3 fs/udf/file.c | 1 fs/udf/inode.c | 2 fs/udf/namei.c | 1 fs/udf/super.c | 6 fs/udf/symlink.c | 1 fs/udf/udf_i.h | 1 fs/udf/udfdecl.h | 1 include/linux/buffer_head.h | 6 include/linux/fs.h | 11 - include/linux/hugetlb.h | 1 mm/hugetlb.c | 10 - virt/kvm/guest_memfd.c | 12 - 52 files changed, 360 insertions(+), 309 deletions(-)
Honza
Previous versions: