Skip to content

amd-xgbe: RX adaptation and PHY handling fixes

Raju Rangoju lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyApplied 3/3
  2. v23 patches 1 replySuperseded
  3. v13 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- use the correct fixes tag for the link status handling patch
- change the data_path_stopped flag to be cleared in phy_start() to ensure it is reset on device restart

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3amd-xgbe: fix link status handling in xgbe_rx_adaptationdrivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c+14 -50 repliesApplied
2/3amd-xgbe: prevent CRC errors during RX adaptation with AN disableddrivers/net/ethernet/amd/xgbe/xgbe-drv.c drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c drivers/net/ethernet/amd/xgbe/xgbe.h+69 -21 replyApplied
3/3amd-xgbe: reset PHY settings before starting PHYdrivers/net/ethernet/amd/xgbe/xgbe-drv.c+6 -90 repliesApplied

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMaxime Chevallier
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net 0/3] amd-xgbe: RX adaptation and PHY handling fixes

This series fixes several issues in the amd-xgbe driver related to RX adaptation and PHY handling in 10GBASE-KR mode, particularly when auto-negotiation is disabled.

Patch 1 fixes link status handling during RX adaptation by correctly reading the latched link status bit so transient link drops are detected without losing the current state.

Patch 2 prevents CRC errors that can occur when performing RX adaptation with auto-negotiation turned off. The driver now stops TX/RX before re-triggering RX adaptation and only re-enables traffic once adaptation completes and the link is confirmed up, ensuring packets are not corrupted during the adaptation window.

Patch 3 restores the intended ordering of PHY reset relative to phy_start(), making sure PHY settings are reset before the PHY is started instead of afterwards.

Changes since v1:
- change the data_path_stopped flag to boolean type as it is only used as a true/false indicator.

Changes since v2:
- use the correct fixes tag for the link status handling patch
- change the data_path_stopped flag to be cleared in phy_start() to ensure it is reset on device restart

Raju Rangoju (3):
amd-xgbe: fix link status handling in xgbe_rx_adaptation
amd-xgbe: prevent CRC errors during RX adaptation with AN disabled
amd-xgbe: reset PHY settings before starting PHY

 drivers/net/ethernet/amd/xgbe/xgbe-drv.c    | 19 ++---
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 82 +++++++++++++++++++--
 drivers/net/ethernet/amd/xgbe/xgbe.h        |  4 +
 3 files changed, 89 insertions(+), 16 deletions(-)
Signature · 1 line
2.34.1