Skip to content

RFC mm/damon: support addr_unit on default monitoring targets for modules

SeongJae Park damon linux-mm lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mm/damon/core: fix wrong end address assignment on walk_system_ram()mm/damon/core.c+1 -10 replies
2/5mm/damon/core: support addr_unit on damon_find_biggest_system_ram()mm/damon/core.c+23 -100 replies
3/5mm/damon/core: receive addr_unit on damon_set_region_biggest_system_ram_default()include/linux/damon.h mm/damon/core.c mm/damon/lru_sort.c +2 more+8 -40 replies
4/5mm/damon/reclaim: respect addr_unit on default monitoring region setupmm/damon/reclaim.c+0 -60 replies
5/5mm/damon/lru_sort: respect addr_unit on default monitoring region setupmm/damon/lru_sort.c+0 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] mm/damon: support addr_unit on default monitoring targets for modules

DAMON_RECLAIM and DAMON_LRU_SORT support 'addr_unit' parameters only when the monitoring target address range is explicitly set. This was intentional for making the initial 'addr_unit' support change small. Now 'addr_unit' support is being quite stabilized. Having the corner case of the support is only making the code inconsistent with implicit rules, that makes it easy to confuse [1] readers. After all, there is no real reason to keep 'addr_unit' support incomplete. Add the support for the case to improve the readability and more completely support 'addr_unit'.

This series is constructed with five patches. The first one (patch 1) fixes a small bug that mistakenly assigns inclusive end address to open end address, which was found from this work. The second and third ones (patches 2 and 3) extend the modules default monitoring target setting functions in the core layer one by one, to support the 'addr_unit' while making no visible changes. The final two patches (patches 4 and 5) update DAMON_RECLAIM and DAMON_LRU_SORT to support 'addr_unit' for the default monitoring target address ranges, by passing the user input to the core functions.

[1] https://lore.kernel.org/[email protected]

SeongJae Park (5):
mm/damon/core: fix wrong end address assignment on walk_system_ram() mm/damon/core: support addr_unit on damon_find_biggest_system_ram() mm/damon/core: receive addr_unit on
damon_set_region_biggest_system_ram_default()
mm/damon/reclaim: respect addr_unit on default monitoring region setup mm/damon/lru_sort: respect addr_unit on default monitoring region
setup

 include/linux/damon.h |  1 +
 mm/damon/core.c       | 36 +++++++++++++++++++++++++-----------
 mm/damon/lru_sort.c   |  7 +------
 mm/damon/reclaim.c    |  7 +------
 mm/damon/stat.c       |  2 +-
 5 files changed, 29 insertions(+), 24 deletions(-)

base-commit: c33b07ff858e4125f60a2b9e2a49f276b0d7e75a

Signature · 1 line
2.47.3