Skip to content

drm/vmwgfx: Use DRM's vblank timer

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- patch 3: fix vblank cancalling in CRTC cleanup (Zack)
- patch 2: mention timer restart in commit message (Zack)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/vmwgfx: Determine lock-waiting timeout from vblank statedrivers/gpu/drm/vmwgfx/vmwgfx_vkms.c+6 -20 replies
2/3drm/vmwgfx: Move vblank handling into separate helperdrivers/gpu/drm/vmwgfx/vmwgfx_vkms.c drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h+26 -120 replies
3/3drm/vmwgfx: Convert to DRM vblank timersdrivers/gpu/drm/vmwgfx/vmwgfx_kms.h drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c +3 more+12 -590 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchZack Rusin
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] drm/vmwgfx: Use DRM's vblank timer

Replace vmwgfx's vblank timer with DRM's shared implementation. The common code is mostly equivalent, but provides additional protection against concurrent changes to the vblank counter.

Patches 1 and 2 align vmwgfx with the shared code, so that it can be converted easily.

The conversion is in patch 3. It replaces vmwgfx's custom timer with calls to DRM's vblank interfaces. Initialization happens internally.

This series should get some more testing.

v2:
- patch 3: fix vblank cancalling in CRTC cleanup (Zack)
- patch 2: mention timer restart in commit message (Zack)

Thomas Zimmermann (3):
drm/vmwgfx: Determine lock-waiting timeout from vblank state drm/vmwgfx: Move vblank handling into separate helper drm/vmwgfx: Convert to DRM vblank timers

 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h  |  2 -
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c  |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c | 70 ++++++++--------------------
 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h |  2 +-
 6 files changed, 24 insertions(+), 53 deletions(-)
Signature · 1 line
2.54.0