Fix various races in xprtrdma
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 0 repliesNew
- v28 patches 3 repliesSuperseded
Changes in v3 from the cover letter
- Drop Eric's patch -- should already be applied
- Fix a bug with frwr_map's tail boundary check
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | xprtrdma: Close sendctx get/put race that can block a transportnet/ | +16 | 0 replies | |
| 2/7 | xprtrdma: Avoid 250 ms delay on backlog wakeupnet/ | +1 | 0 replies | |
| 3/7 | xprtrdma: Close lost-wakeup race in xprt_rdma_alloc_slotinclude/ net/ net/ | +32 | 0 replies | |
| 4/7 | xprtrdma: Decouple frwr_wp_create from frwr_mapnet/ | +50 | 0 replies | |
| 5/7 | xprtrdma: Replace rpcrdma_mr_seg with xdr_buf cursorinclude/ net/ net/ +1 more | +193 | 0 replies | |
| 6/7 | xprtrdma: Scale receive batch size with credit windownet/ net/ net/ | +4 | 0 replies | |
| 7/7 | xprtrdma: Post receive buffers after RPC completionnet/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/7] Fix various races in xprtrdma
From: Chuck Lever <[email protected]>
Since commit b326df4a8ec6 ("NFS: enable nconnect for RDMA"), the nconnect mount option has been enabled on proto=rdma NFS mount points. Utilizing this option increases the IOPS throughput that an NFS mount point is capable of.
To test some ongoing NFS server performance scalability work, I've started to enable nconnect while testing. I've found that, as well as enabling much better utilization of fast network fabrics, it surfaces some subtle race conditions that are well-buried when there is only a single QP.
This series addresses a few bugs and makes some performance scalability enhancements to make nconnect with NFS/RDMA even better.
Base commit: 11439c4635edd669ae435eec308f4ab8a0804808
---
Changes since v2:
- Drop Eric's patch -- should already be applied
- Fix a bug with frwr_map's tail boundary check
Chuck Lever (7):
xprtrdma: Close sendctx get/put race that can block a transport
xprtrdma: Avoid 250 ms delay on backlog wakeup
xprtrdma: Close lost-wakeup race in xprt_rdma_alloc_slot
xprtrdma: Decouple frwr_wp_create from frwr_map
xprtrdma: Replace rpcrdma_mr_seg with xdr_buf cursor
xprtrdma: Scale receive batch size with credit window
xprtrdma: Post receive buffers after RPC completion
include/linux/sunrpc/xprt.h | 2 + include/trace/events/rpcrdma.h | 28 ++--- net/sunrpc/xprt.c | 16 +++ net/sunrpc/xprtrdma/frwr_ops.c | 177 ++++++++++++++++++++++++++------ net/sunrpc/xprtrdma/rpc_rdma.c | 177 ++++++++++++-------------------- net/sunrpc/xprtrdma/transport.c | 17 ++- net/sunrpc/xprtrdma/verbs.c | 19 +++- net/sunrpc/xprtrdma/xprt_rdma.h | 43 +++++--- 8 files changed, 305 insertions(+), 174 deletions(-)
Signature · 1 line
2.53.0