Skip to content

wifi: mt76: mt7925: fix up MLO link lifetime and error handling

Sean Wang linux-mediatek linux-wireless oe-kbuild-all 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19wifi: mt76: mt7925: pass mlink to sta_amsdu_tlv()drivers/net/wireless/mediatek/mt76/mt7925/mcu.c+6 -50 replies
2/19wifi: mt76: mt7925: pass WCID indices to bss_basic_tlv()drivers/net/wireless/mediatek/mt76/mt7925/main.c drivers/net/wireless/mediatek/mt76/mt7925/mcu.c drivers/net/wireless/mediatek/mt76/mt7925/mcu.h+73 -360 replies
3/19wifi: mt76: mt7925: pass mlink and mconf to sta_mld_tlv()drivers/net/wireless/mediatek/mt76/mt7925/mcu.c+36 -170 replies
4/19wifi: mt76: mt7925: pass mlink to mcu_sta_update()drivers/net/wireless/mediatek/mt76/mt7925/mac.c drivers/net/wireless/mediatek/mt76/mt7925/main.c drivers/net/wireless/mediatek/mt76/mt7925/mcu.c +1 more+28 -180 replies
5/19wifi: mt76: mt7925: resolve primary mlink via def_wciddrivers/net/wireless/mediatek/mt76/mt7925/main.c+10 -10 replies
6/19wifi: mt76: mt7925: pass mlink to mac_link_sta_remove()drivers/net/wireless/mediatek/mt76/mt7925/main.c+3 -70 replies
7/19wifi: mt76: mt7925: pass mlink to sta_hdr_trans_tlv()drivers/net/wireless/mediatek/mt76/mt7925/mcu.c+11 -130 replies
8/19wifi: mt76: mt7925: validate mlink in sta_hdr_trans_tlv()drivers/net/wireless/mediatek/mt76/mt7925/mcu.c+3 -30 replies
9/19wifi: mt76: mt7925: pass mlink to wtbl_update_hdr_trans()drivers/net/wireless/mediatek/mt76/mt7925/main.c drivers/net/wireless/mediatek/mt76/mt7925/mcu.c drivers/net/wireless/mediatek/mt76/mt7925/mt7925.h+4 -70 replies
10/19wifi: mt76: mt7925: pass mlink to set_link_key()drivers/net/wireless/mediatek/mt76/mt7925/main.c+9 -50 replies
11/19wifi: mt76: mt7925: resolve link after acquiring mt76 mutexdrivers/net/wireless/mediatek/mt76/mt7925/main.c+2 -20 replies
12/19wifi: mt76: mt7925: pass mconf and mlink to wtbl_update_hdr_trans()drivers/net/wireless/mediatek/mt76/mt7925/main.c drivers/net/wireless/mediatek/mt76/mt7925/mcu.c drivers/net/wireless/mediatek/mt76/mt7925/mt7925.h+9 -200 replies
13/19wifi: mt76: mt7925: make WCID cleanup unconditional in sta_remove_links()drivers/net/wireless/mediatek/mt76/mt7925/main.c+2 -40 replies
14/19wifi: mt76: mt7925: unwind WCID setup on link STA add failuredrivers/net/wireless/mediatek/mt76/mt7925/main.c+38 -150 replies
15/19wifi: mt76: mt7925: drop WCID reinit after publishdrivers/net/wireless/mediatek/mt76/mt7925/main.c+0 -10 replies
16/19wifi: mt76: mt7925: move WCID teardown into link_sta_remove()drivers/net/wireless/mediatek/mt76/mt7925/main.c+8 -80 replies
17/19wifi: mt76: mt7925: switch link STA allocation to RCU lifetimedrivers/net/wireless/mediatek/mt76/mt7925/main.c drivers/net/wireless/mediatek/mt76/mt792x.h+8 -30 replies
18/19wifi: mt76: mt7925: publish msta->link after successful link adddrivers/net/wireless/mediatek/mt76/mt7925/main.c+14 -40 replies
19/19wifi: mt76: mt7925: host-only unwind published links on add failuredrivers/net/wireless/mediatek/mt76/mt7925/main.c+45 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] wifi: mt76: mt7925: fix up MLO link lifetime and error handling

From: Sean Wang <[email protected]>

Hi,

This series fix up MLO link STA lifetime and error handling in mt7925.

The current add path may expose partially initialized links and does not reliably release host resources when firmware commands fail (e.g. MCU timeouts). In addition, several helpers internally look up mlink, creating implicit dependencies on driver state and making the code harder to reason about and maintain.

Switch link STA handling to RCU lifetime, align WCID publish/teardown ordering, pass mlink explicitly to helpers, and add host-side unwind logic to release resources when link add fails.

Sean

Sean Wang (19):
wifi: mt76: mt7925: pass mlink to sta_amsdu_tlv()
wifi: mt76: mt7925: pass WCID indices to bss_basic_tlv()
wifi: mt76: mt7925: pass mlink and mconf to sta_mld_tlv()
wifi: mt76: mt7925: pass mlink to mcu_sta_update()
wifi: mt76: mt7925: resolve primary mlink via def_wcid
wifi: mt76: mt7925: pass mlink to mac_link_sta_remove()
wifi: mt76: mt7925: pass mlink to sta_hdr_trans_tlv()
wifi: mt76: mt7925: validate mlink in sta_hdr_trans_tlv()
wifi: mt76: mt7925: pass mlink to wtbl_update_hdr_trans()
wifi: mt76: mt7925: pass mlink to set_link_key()
wifi: mt76: mt7925: resolve link after acquiring mt76 mutex
wifi: mt76: mt7925: pass mconf and mlink to wtbl_update_hdr_trans()
wifi: mt76: mt7925: make WCID cleanup unconditional in
sta_remove_links()
wifi: mt76: mt7925: unwind WCID setup on link STA add failure
wifi: mt76: mt7925: drop WCID reinit after publish
wifi: mt76: mt7925: move WCID teardown into link_sta_remove()
wifi: mt76: mt7925: switch link STA allocation to RCU lifetime
wifi: mt76: mt7925: publish msta->link after successful link add
wifi: mt76: mt7925: host-only unwind published links on add failure

 .../net/wireless/mediatek/mt76/mt7925/mac.c   |   3 +-
 .../net/wireless/mediatek/mt76/mt7925/main.c  | 221 +++++++++++++-----
 .../net/wireless/mediatek/mt76/mt7925/mcu.c   | 180 +++++++-------
 .../net/wireless/mediatek/mt76/mt7925/mcu.h   |   7 +
 .../wireless/mediatek/mt76/mt7925/mt7925.h    |   8 +-
 drivers/net/wireless/mediatek/mt76/mt792x.h   |   1 +
 6 files changed, 280 insertions(+), 140 deletions(-)
Signature · 1 line
2.43.0