Skip to content

Convert most Dell WMI drivers to use the new buffer-based API

Armin Wolf linux-hwmon lkml platform-driver-x86 sashiko-reviews 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest9 patches 7 repliesIn review
  2. v59 patches 6 repliesSuperseded
  3. v49 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v39 patches13 repliesSuperseded
v29 patches1 replySuperseded
v19 patches10 repliesSuperseded

Changes in v6 from the cover letter

- mark pseudo-strings in dell-wmi-descriptor as __nonstring
- rework placement of variables being used with __free()
- use __free() in dell-smm-hwmon
- keep original logic in dell-wmi-base
- add Reviewed-by tags

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9platform/x86: dell-descriptor: Use new buffer-based WMI APIdrivers/platform/x86/dell/dell-wmi-descriptor.c+48 -600 replies
2/9platform/x86: dell-privacy: Use new buffer-based WMI APIdrivers/platform/x86/dell/dell-wmi-privacy.c+34 -430 replies
3/9platform/x86: dell-smbios-wmi: Use new buffer-based WMI APIdrivers/platform/x86/dell/dell-smbios-wmi.c+17 -230 replies
4/9platform/x86: dell-wmi-base: Use new buffer-based WMI APIdrivers/platform/x86/dell/dell-wmi-base.c+28 -320 replies
5/9platform/x86: dell-ddv: Use new buffer-based WMI APIdrivers/platform/x86/dell/dell-wmi-ddv.c+85 -942 replies
6/9hwmon: (dell-smm) Use new buffer-based WMI APIdrivers/hwmon/dell-smm-hwmon.c+17 -321 reply
7/9platform/wmi: Make wmi_bus_class constdrivers/platform/wmi/core.c+1 -10 replies
8/9platform/wmi: Make sysfs attributes constdrivers/platform/wmi/core.c+18 -110 replies
9/9modpost: Handle malformed WMI GUID stringsDocumentation/wmi/driver-development-guide.rst scripts/mod/file2alias.c+28 -22 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by.

PatchGuenter RoeckIlpo Järvinen
1/9
2/9
3/9
4/9
5/9
6/9A-b
7/9R-b
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/9] Convert most Dell WMI drivers to use the new buffer-based API

The new buffer-based WMI API improves the compatibility between different ACPI firmware implementations by performing marshalling/ unmarshalling of WMI buffers like the original Windows driver.

Convert most Dell WMI drivers to use this new API. This also removes all ACPI-related code from those drivers because the new buffer-based WMI API uses abstract WMI buffer objects instead of ACPI objects.

All drivers have been tested on a Dell Inspiron 3505 and appear to work normally.

The last three patches contain some misc. cleanups for the WMI driver core itself. The most important change is a fix for modprobe to verify any WMI GUID strings from WMI drivers and convert them to uppercase if necessary. This should fix autoloading for WMI drivers that use WMI GUID strings with lowercase letters.

The whole series should be applied on the platform drivers tree.

Changes since v5:
- mark pseudo-strings in dell-wmi-descriptor as __nonstring
- rework placement of variables being used with __free()
- use __free() in dell-smm-hwmon
- keep original logic in dell-wmi-base
- add Reviewed-by tags

Changes since v4:
- fix issues found by Sashiko review

Changes since v3:
- rework patches to work with the revised WMI API
- use __free() for cleanup
- add missing includes

Changes since v2:
- add Acked-by tag from Guenter
- rework buffer parsing in dell-wmi-descriptor as suggested by Gergo

Changes since v1:
- do not perform pointer arithmetic on void pointers in dell-smm-hwmon

Armin Wolf (9):
platform/x86: dell-descriptor: Use new buffer-based WMI API platform/x86: dell-privacy: Use new buffer-based WMI API platform/x86: dell-smbios-wmi: Use new buffer-based WMI API platform/x86: dell-wmi-base: Use new buffer-based WMI API platform/x86: dell-ddv: Use new buffer-based WMI API
hwmon: (dell-smm) Use new buffer-based WMI API platform/wmi: Make wmi_bus_class const platform/wmi: Make sysfs attributes const
modpost: Handle malformed WMI GUID strings

 .../wmi/driver-development-guide.rst          |   2 +-
 drivers/hwmon/dell-smm-hwmon.c                |  49 ++---
 drivers/platform/wmi/core.c                   |  31 +--
 drivers/platform/x86/dell/dell-smbios-wmi.c   |  40 ++--
 drivers/platform/x86/dell/dell-wmi-base.c     |  60 +++---
 drivers/platform/x86/dell/dell-wmi-ddv.c      | 179 +++++++++---------
 .../platform/x86/dell/dell-wmi-descriptor.c   | 108 +++++------
 drivers/platform/x86/dell/dell-wmi-privacy.c  |  77 ++++----
 scripts/mod/file2alias.c                      |  28 ++-
 9 files changed, 276 insertions(+), 298 deletions(-)
Signature · 1 line
2.39.5