Convert most Dell WMI drivers to use the new buffer-based API
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest9 patches 7 repliesIn review
- v59 patches 6 repliesSuperseded
- v49 patches 0 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 9 patches | 13 replies | Superseded | |
| v2 | 9 patches | 1 reply | Superseded | |
| v1 | 9 patches | 10 replies | Superseded |
Changes in v6 from the cover letter
- mark pseudo-strings in dell-wmi-descriptor as __nonstring
- rework placement of variables being used with __free()
- use __free() in dell-smm-hwmon
- keep original logic in dell-wmi-base
- add Reviewed-by tags
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | platform/x86: dell-descriptor: Use new buffer-based WMI APIdrivers/ | +48 | 0 replies | |
| 2/9 | platform/x86: dell-privacy: Use new buffer-based WMI APIdrivers/ | +34 | 0 replies | |
| 3/9 | platform/x86: dell-smbios-wmi: Use new buffer-based WMI APIdrivers/ | +17 | 0 replies | |
| 4/9 | platform/x86: dell-wmi-base: Use new buffer-based WMI APIdrivers/ | +28 | 0 replies | |
| 5/9 | platform/x86: dell-ddv: Use new buffer-based WMI APIdrivers/ | +85 | 2 replies | |
| 6/9 | hwmon: (dell-smm) Use new buffer-based WMI APIdrivers/ | +17 | 1 reply | |
| 7/9 | platform/wmi: Make wmi_bus_class constdrivers/ | +1 | 0 replies | |
| 8/9 | platform/wmi: Make sysfs attributes constdrivers/ | +18 | 0 replies | |
| 9/9 | modpost: Handle malformed WMI GUID stringsDocumentation/ scripts/ | +28 | 2 replies |
Reviews trailers per patch
3 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Guenter Roeck | Ilpo Järvinen |
|---|---|---|
| 1/9 | ||
| 2/9 | ||
| 3/9 | ||
| 4/9 | ||
| 5/9 | ||
| 6/9 | A-b | |
| 7/9 | R-b | |
| 8/9 | R-b | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/9] Convert most Dell WMI drivers to use the new buffer-based API
The new buffer-based WMI API improves the compatibility between different ACPI firmware implementations by performing marshalling/ unmarshalling of WMI buffers like the original Windows driver.
Convert most Dell WMI drivers to use this new API. This also removes all ACPI-related code from those drivers because the new buffer-based WMI API uses abstract WMI buffer objects instead of ACPI objects.
All drivers have been tested on a Dell Inspiron 3505 and appear to work normally.
The last three patches contain some misc. cleanups for the WMI driver core itself. The most important change is a fix for modprobe to verify any WMI GUID strings from WMI drivers and convert them to uppercase if necessary. This should fix autoloading for WMI drivers that use WMI GUID strings with lowercase letters.
The whole series should be applied on the platform drivers tree.
Changes since v5:
- mark pseudo-strings in dell-wmi-descriptor as __nonstring
- rework placement of variables being used with __free()
- use __free() in dell-smm-hwmon
- keep original logic in dell-wmi-base
- add Reviewed-by tags
Changes since v4:
- fix issues found by Sashiko review
Changes since v3:
- rework patches to work with the revised WMI API
- use __free() for cleanup
- add missing includes
Changes since v2:
- add Acked-by tag from Guenter
- rework buffer parsing in dell-wmi-descriptor as suggested by Gergo
Changes since v1:
- do not perform pointer arithmetic on void pointers in dell-smm-hwmon
Armin Wolf (9):
platform/x86: dell-descriptor: Use new buffer-based WMI API platform/x86: dell-privacy: Use new buffer-based WMI API platform/x86: dell-smbios-wmi: Use new buffer-based WMI API platform/x86: dell-wmi-base: Use new buffer-based WMI API platform/x86: dell-ddv: Use new buffer-based WMI API
hwmon: (dell-smm) Use new buffer-based WMI API platform/wmi: Make wmi_bus_class const platform/wmi: Make sysfs attributes const
modpost: Handle malformed WMI GUID strings
.../wmi/driver-development-guide.rst | 2 +- drivers/hwmon/dell-smm-hwmon.c | 49 ++--- drivers/platform/wmi/core.c | 31 +-- drivers/platform/x86/dell/dell-smbios-wmi.c | 40 ++-- drivers/platform/x86/dell/dell-wmi-base.c | 60 +++--- drivers/platform/x86/dell/dell-wmi-ddv.c | 179 +++++++++--------- .../platform/x86/dell/dell-wmi-descriptor.c | 108 +++++------ drivers/platform/x86/dell/dell-wmi-privacy.c | 77 ++++---- scripts/mod/file2alias.c | 28 ++- 9 files changed, 276 insertions(+), 298 deletions(-)
Signature · 1 line
2.39.5