Skip to content

ASoC: wm_adsp: Some improvements to firmware file search

Richard Fitzgerald linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ASoC: wm_adsp: Remove unused argument to wm_adsp_release_firmware_files()sound/soc/codecs/wm_adsp.c+3 -60 replies
2/10ASoC: wm_adsp: Add KUnit redirection stubs for firmware file searchsound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h+43 -100 replies
3/10ASoC: wm_adsp: Export function for KUnit test to get firmware filenamessound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h+12 -00 replies
4/10ASoC: wm_adsp: Add kunit test for firmware file searchsound/soc/codecs/Kconfig sound/soc/codecs/Makefile sound/soc/codecs/wm_adsp_fw_find_test.c+1238 -10 replies
5/10ASoC: wm_adsp: Remove duplicated code to find firmware filesound/soc/codecs/wm_adsp.c+7 -200 replies
6/10ASoC: wm_adsp: Use consistent error checks in wm_adsp_request_firmware_files()sound/soc/codecs/wm_adsp.c+65 -270 replies
7/10ASoC: wm_adsp: Convert '/' to '-' when normalizing firmware filenamessound/soc/codecs/wm_adsp.c+4 -50 replies
8/10ASoC: wm_adsp: Add KUnit test cases for '/' in firmware filenamessound/soc/codecs/wm_adsp_fw_find_test.c+15 -00 replies
9/10ASoC: wm_adsp: Use a struct to pass around firmware struct and filenamesound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h sound/soc/codecs/wm_adsp_fw_find_test.c+77 -1140 replies
10/10ASoC: wm_adsp: Combine some similar code in firmware file searchsound/soc/codecs/wm_adsp.c+22 -270 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] ASoC: wm_adsp: Some improvements to firmware file search

This series makes some improvements to the code that searches for firmware files.

Patch 1 is a trivial patch to remove an unused function argument, before
adding any new code that uses this API.

Patches 2..4 add KUnit testing to prove that the subsequent changes don't
break anything.

The remaining patches remove duplicated code and clean up some of the implementation.

Richard Fitzgerald (10):
ASoC: wm_adsp: Remove unused argument to
wm_adsp_release_firmware_files()
ASoC: wm_adsp: Add KUnit redirection stubs for firmware file search
ASoC: wm_adsp: Export function for KUnit test to get firmware
filenames
ASoC: wm_adsp: Add kunit test for firmware file search
ASoC: wm_adsp: Remove duplicated code to find firmware file
ASoC: wm_adsp: Use consistent error checks in
wm_adsp_request_firmware_files()
ASoC: wm_adsp: Convert '/' to '-' when normalizing firmware filenames
ASoC: wm_adsp: Add KUnit test cases for '/' in firmware filenames
ASoC: wm_adsp: Use a struct to pass around firmware struct and
filename
ASoC: wm_adsp: Combine some similar code in firmware file search

 sound/soc/codecs/Kconfig                |   14 +-
 sound/soc/codecs/Makefile               |    2 +
 sound/soc/codecs/wm_adsp.c              |  234 +++--
 sound/soc/codecs/wm_adsp.h              |   19 +
 sound/soc/codecs/wm_adsp_fw_find_test.c | 1221 +++++++++++++++++++++++
 5 files changed, 1383 insertions(+), 107 deletions(-)
 create mode 100644 sound/soc/codecs/wm_adsp_fw_find_test.c
Signature · 1 line
2.47.3