Skip to content

dbtr: Fixes and heterogeneous trigger types

Nicholas Piggin opensbi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18dbtr: Add consistent range checks to trigger ecallslib/sbi/sbi_dbtr.c+24 -33 replies
2/18dbtr: Trigger update should set sbiret.value on failureinclude/sbi/sbi_dbtr.h lib/sbi/sbi_dbtr.c lib/sbi/sbi_ecall_dbtr.c+5 -31 reply
3/18dbtr: Fix endian conversion in trigger install handlerlib/sbi/sbi_dbtr.c+5 -41 reply
4/18dbtr: Return correct error on install not supportedlib/sbi/sbi_dbtr.c+1 -11 reply
5/18dbtr: Do not support chain bitlib/sbi/sbi_dbtr.c+12 -22 replies
6/18dbtr: Improve trigger update error checkinglib/sbi/sbi_dbtr.c+26 -72 replies
7/18dbtr: Check for invalid and unsupported triggers in updatelib/sbi/sbi_dbtr.c+18 -21 reply
8/18dbtr: Improve error handling for trigger enable, disable, uninstalllib/sbi/sbi_dbtr.c+24 -40 replies
9/18dbtr: Read triggers should not read HW trigger if not mappedlib/sbi/sbi_dbtr.c+19 -70 replies
10/18dbtr: Avoid crash in sbi_debug_read_triggerslib/sbi/sbi_dbtr.c+4 -20 replies
11/18dbtr: Succeed operations with no triggers in masklib/sbi/sbi_dbtr.c+9 -00 replies
12/18dbtr: Move hardware trigger probing to a functionlib/sbi/sbi_dbtr.c+48 -410 replies
13/18dbtr: Rework install and update error handlinglib/sbi/sbi_dbtr.c+30 -240 replies
14/18dbtr: Decouple dbtr trigger index from hardware trigger numberinclude/sbi/sbi_dbtr.h lib/sbi/sbi_dbtr.c+76 -250 replies
15/18dbtr: Move trigger feature support test into a functionlib/sbi/sbi_dbtr.c+9 -40 replies
16/18dbtr: Heterogeneous trigger type supportlib/sbi/sbi_dbtr.c+74 -300 replies
17/18dbtr: Heterogeneous access type matching for mcontrol triggersinclude/sbi/sbi_dbtr.h lib/sbi/sbi_dbtr.c+76 -20 replies
18/18dbtr: Work around specification bug in range checkslib/sbi/sbi_dbtr.c+4 -70 replies

Reviews trailers per patch

5 of 18 patches have a Reviewed-by or Acked-by.

PatchHimanshu Chauhan
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18
7/18
8/18
9/18
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] dbtr: Fixes and heterogeneous trigger types

In the course of implementing and testing heterogeneous trigger types as found in the Tenstorrent Ascalon CPU, I found some issues to fix as well.

Patches 1-11 contain fixes and improvements for existing function, and make most of the new kvm-unit-tests tests pass. 12-17 implement "heterogenous" triggers where different HW triggers support different functions so we have to relax the 1:1 mapping from DBTR trig to HW trigger index and allocate HW triggers independently from what can satisfy the requested type. Patch 18 is another possible fix but it relies on update to SBI spec so I put it last. I can move it ahead into the fixes block if the issue is confirmed.

Thanks,
Nick

Nicholas Piggin (18):
dbtr: Add consistent range checks to trigger ecalls
dbtr: Trigger update should set sbiret.value on failure
dbtr: Fix endian conversion in trigger install handler
dbtr: Return correct error on install not supported
dbtr: Do not support chain bit
dbtr: Improve trigger update error checking
dbtr: Check for invalid and unsupported triggers in update
dbtr: Improve error handling for trigger enable, disable, uninstall
dbtr: Read triggers should not read HW trigger if not mapped
dbtr: Avoid crash in sbi_debug_read_triggers
dbtr: Succeed operations with no triggers in mask
dbtr: Move hardware trigger probing to a function
dbtr: Rework install and update error handling
dbtr: Decouple dbtr trigger index from hardware trigger number
dbtr: Move trigger feature support test into a function
dbtr: Heterogeneous trigger type support
dbtr: Heterogeneous access type matching for mcontrol triggers
dbtr: Work around specification bug in range checks

 include/sbi/sbi_dbtr.h   |  17 +-
 lib/sbi/sbi_dbtr.c       | 499 ++++++++++++++++++++++++++++++---------
 lib/sbi/sbi_ecall_dbtr.c |   2 +-
 3 files changed, 407 insertions(+), 111 deletions(-)
Signature · 7 lines
2.51.0


-- 
opensbi mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/opensbi