Skip to content

tools/xenstored: add support for watch depth feature

Juergen Gross xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 5 repliesIn review
  2. v18 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- some minor stale changes reverted
- last patch covered by the series now, man page updated

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tools/xenstored: allow domU to get own featuresdocs/misc/xenstore.txt tools/xenstored/core.c tools/xenstored/domain.c+17 -110 replies
2/9docs: clarify Xenstore watch depth featuredocs/misc/xenstore.txt+4 -10 replies
3/9tools/libs/store: add support to use watches with a depth parameterdocs/man/xl.cfg.5.pod.in tools/include/xenstore.h tools/libs/store/libxenstore.map +2 more+116 -123 replies
4/9tools/xenstored: add depth information to watchestools/xenstored/lu.c tools/xenstored/watch.c tools/xenstored/watch.h+81 -330 replies
5/9tools/xenstored: add depth handling to XS_WATCHtools/xenstored/domain.c tools/xenstored/domain.h tools/xenstored/watch.c+19 -20 replies
6/9tools/xenstored: replace the fire_watches() exact parametertools/xenstored/core.c tools/xenstored/transaction.c tools/xenstored/transaction.h +2 more+55 -260 replies
7/9tools/xenstored: expand special watch handling with depth featuretools/xenstored/domain.c+26 -80 replies
8/9tools/xenstored: make XENSTORE_SERVER_FEATURE_WATCHDEPTH availabletools/xenstored/domain.c+2 -10 replies
9/9tools/xs-clients: support depth with xenstore-watchdocs/man/xenstore-watch.1.pod tools/xs-clients/xenstore_client.c+24 -40 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJason Andryuk
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] tools/xenstored: add support for watch depth feature

In order to reduce excessive number of watch events the watch depth feature has been defined, allowing the user to limit the number of node levels below the watched node to cause events.

This series is implementing this feature for xenstored (including the PV and PVH stubdom variants).

Possible users are:

- xl/libxl: use domid information for the special @introduceDomain and @releaseDomain watches, which will be available when using depth = 1

- xenconsoled, like xl/libxl

- any PV-device backends watching directories for added devices (no watch events when any device specific node is modified)

- any PV-device frontend and backend watching the "state" node of the other side, in case the other side plays dirty games by building large sub-trees beneath the "state" node

Changes in V2:
- some minor stale changes reverted
- last patch covered by the series now, man page updated

Juergen Gross (9):
tools/xenstored: allow domU to get own features
docs: clarify Xenstore watch depth feature tools/libs/store: add support to use watches with a depth parameter tools/xenstored: add depth information to watches tools/xenstored: add depth handling to XS_WATCH tools/xenstored: replace the fire_watches() exact parameter tools/xenstored: expand special watch handling with depth feature tools/xenstored: make XENSTORE_SERVER_FEATURE_WATCHDEPTH available tools/xs-clients: support depth with xenstore-watch

 docs/man/xenstore-watch.1.pod      |   9 ++
 docs/man/xl.cfg.5.pod.in           |   6 ++
 docs/misc/xenstore.txt             |  14 ++-
 tools/include/xenstore.h           |  16 +++
 tools/libs/store/libxenstore.map   |   2 +
 tools/libs/store/xs.c              | 102 +++++++++++++++---
 tools/xenstored/core.c             |  15 ++-
 tools/xenstored/domain.c           |  61 ++++++++---
 tools/xenstored/domain.h           |   2 +
 tools/xenstored/lu.c               |   3 +
 tools/xenstored/transaction.c      |  14 +--
 tools/xenstored/transaction.h      |   4 +-
 tools/xenstored/watch.c            | 161 ++++++++++++++++++++---------
 tools/xenstored/watch.h            |  10 +-
 tools/xs-clients/xenstore_client.c |  19 +++-
 xen/include/public/io/xs_wire.h    |   2 +
 16 files changed, 343 insertions(+), 97 deletions(-)
Signature · 1 line
2.53.0