lib/iov_iter: fix bugs found via cross-function consistency review
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | lib/iov_iter: fix missing allocation failure check in iov_iter_extract_bvec_pages()lib/ | +2 | 3 replies | |
| 2/7 | lib/iov_iter: add NULL check on folioq->prev in iov_iter_folioq_revert()lib/ | +2 | 0 replies | |
| 3/7 | lib/iov_iter: fix misplaced parenthesis in iov_iter_restore() kvec checklib/ | +1 | 2 replies | |
| 4/7 | lib/iov_iter: account for iov_offset in iov_iter_single_seg_count() folioq pathlib/ | +2 | 0 replies | |
| 5/7 | lib/iov_iter: account for iov_offset in iov_iter_gap_alignment()lib/ | +7 | 0 replies | |
| 6/7 | lib/iov_iter: guard iov_iter_alignment() against zero-count iovec/bvec iteratorslib/ | +2 | 0 replies | |
| 7/7 | lib/iov_iter: add missing should_fail_usercopy() in copy_to_user_iter_mc()lib/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] lib/iov_iter: fix bugs found via cross-function consistency review
A systematic review of lib/iov_iter.c checking that each iterator type is handled consistently across all functions turned up seven issues:
- Two can cause kernel oops: a missing allocation failure check in iov_iter_extract_bvec_pages() (NULL deref under memory pressure), and a missing NULL check in iov_iter_folioq_revert() (NULL deref when reverting past the head of a folio_queue chain).
- Two return wrong values for partially consumed iterators:
iov_iter_single_seg_count() ignores iov_offset for folioq, and iov_iter_gap_alignment() ignores iov_offset for the first iovec segment.
- One fires a spurious WARN_ON_ONCE for kvec iterators in iov_iter_restore() due to a misplaced parenthesis.
- One can read out of bounds: iov_iter_alignment_iovec/bvec enter their do-while loops unconditionally even when count is zero.
- One is a testing gap: copy_to_user_iter_mc() lacks the should_fail_usercopy() check present in all other copy helpers.
All found through code review; no runtime failures were needed to discover them. Each patch is independent and can be applied separately.
Josh Law (7):
lib/iov_iter: fix missing allocation failure check in
iov_iter_extract_bvec_pages()
lib/iov_iter: add NULL check on folioq->prev in
iov_iter_folioq_revert()
lib/iov_iter: fix misplaced parenthesis in iov_iter_restore() kvec
check
lib/iov_iter: account for iov_offset in iov_iter_single_seg_count()
folioq path
lib/iov_iter: account for iov_offset in iov_iter_gap_alignment() lib/iov_iter: guard iov_iter_alignment() against zero-count iovec/bvec
iterators
lib/iov_iter: add missing should_fail_usercopy() in
copy_to_user_iter_mc()
lib/iov_iter.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-)
Signature · 1 line
2.34.1