Skip to content

i2c: rtl9300: support for RTL9607C I2C controller

Rustam Adilov linux-devicetree linux-i2c lkml 6 versions – Applied

Status from this message: merged to i2c/i2c-host.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 1 replyApplied
  2. v58 patches 4 repliesSuperseded
  3. v48 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v38 patches4 repliesSuperseded
v28 patches5 repliesSuperseded
v18 patches11 repliesSuperseded

Changes in v6 from the cover letter

- fixed a typo in the commit subject of Patch 7 "intoduce -> introduce".
- added "Acked-by Conor Dooley" to Patch 5.
- Link to v5: https://lore.kernel.org/linux-i2c/[email protected]/

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/8i2c: rtl9300: split data_reg into read and write regdrivers/i2c/busses/i2c-rtl9300.c+15 -100 replies
2/8i2c: rtl9300: introduce max length property to driver datadrivers/i2c/busses/i2c-rtl9300.c+8 -10 replies
3/8i2c: rtl9300: introduce F_BUSY to the reg_fields structdrivers/i2c/busses/i2c-rtl9300.c+4 -10 replies
4/8i2c: rtl9300: introduce a property for 8 bit width reg addressdrivers/i2c/busses/i2c-rtl9300.c+7 -10 replies
5/8dt-bindings: i2c: realtek,rtl9301-i2c: extend for clocks and RTL9607C supportDocumentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml+15 -00 replies
6/8i2c: rtl9300: introduce clk struct for upcoming rtl9607 supportdrivers/i2c/busses/i2c-rtl9300.c+8 -00 replies
7/8i2c: rtl9300: introduce new function properties to driver datadrivers/i2c/busses/i2c-rtl9300.c+44 -220 replies
8/8i2c: rtl9300: add RTL9607C i2c controller supportdrivers/i2c/busses/i2c-rtl9300.c+70 -00 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchChris PackhamConor Dooley
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8A-b
6/8R-b
7/8
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/8] i2c: rtl9300: support for RTL9607C I2C controller

This patch series for the RTL9300 I2C driver adds i2c support for RTL9607C SoC. They are somewhat different to the RTL9300 and RTL9310 but not enough to warrant a new whole driver.

The patch series was split into patches that add/change something in the driver to smooth out the RTL9607C support addition in the end and for ease of review. Because of that, the patch 8 depends on all the prior patches before it.

RTL9607C primarly uses the i2c controller for communication with laser driver over on i2c interface 1 or 2.

I have successfully tested the byte read operations on my RTL9607C board which has GN25L95 laser driver in OpenWrt.

This patch series depends on the patch [1] from Jan Kantert to be applied first before applying my patch series.

[1] -
https://lore.kernel.org/all/[email protected]/

---
Changelog in v6
- fixed a typo in the commit subject of Patch 7 "intoduce -> introduce".
- added "Acked-by Conor Dooley" to Patch 5.
- Link to v5: https://lore.kernel.org/linux-i2c/[email protected]/

Changelog in v5
- reworded the commit message in Patch 5 to make it clear that the existing devices also have i2c master controller clocks.
- Link to v4: https://lore.kernel.org/linux-i2c/[email protected]/

Changelog in v4
- moved the patch 7 that changes bindings to be before patch 5 where clk
is introduced in the driver.
- changed the "realtek,rtl9607-i2c" compatible to require the "clocks" to be specified and with it moved it out of "realtek,rtl9310-i2c" check to its own place for cleanliness (how it was originally in v1).
- Link to v3: https://lore.kernel.org/linux-i2c/[email protected]/

Changelog in v3
- Patch 7
- reworded the commit message to better describe i2c clock.
- make clocks property available for all compatibles.
- change "realtek,rtl9607-i2c" compatible to be under the same if statement

    as "realtek,rtl9310-i2c" for "realtek,scl".

- Link to v2: https://lore.kernel.org/linux-i2c/[email protected]/

Changelog in v2
- rebased on top of the patch from Jan Kantert.
- Patch 7 (to my best understanding of Krzysztof's request):
- added the "clocks: false" for compatibles that are not realtek,rtl9607-i2c.
- Link to v1: https://lore.kernel.org/linux-i2c/[email protected]/

Rustam Adilov (8):
i2c: rtl9300: split data_reg into read and write reg
i2c: rtl9300: introduce max length property to driver data
i2c: rtl9300: introduce F_BUSY to the reg_fields struct
i2c: rtl9300: introduce a property for 8 bit width reg address
dt-bindings: i2c: realtek,rtl9301-i2c: extend for clocks and RTL9607C
support
i2c: rtl9300: introduce clk struct for upcoming rtl9607 support
i2c: rtl9300: introduce new function properties to driver data
i2c: rtl9300: add RTL9607C i2c controller support

 .../bindings/i2c/realtek,rtl9301-i2c.yaml     |  15 ++
 drivers/i2c/busses/i2c-rtl9300.c              | 191 ++++++++++++++----
 2 files changed, 171 insertions(+), 35 deletions(-)
Signature · 1 line
2.53.0