Skip to content

iio: ssp_sensors: improve resource cleanup

Sanjay Chitroda linux-iio lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest9 patches 26 repliesIn review
  2. v67 patches 15 repliesApplied
  3. v55 patches 15 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v44 patches7 repliesSuperseded
v33 patches6 repliesSuperseded

Changes in v7 from the cover letter

- first 2 checkpatch patches are applied to iio/testing
- address coding type review comment from Andy at multiple places
- add warning fix in ssp_dev driver
- add new change to cancel refresh work
- add helper API for enable/disable MCU
- Following input from Andy add local variable dev to use with APIs
- v6 series: https://lore.kernel.org/all/[email protected]/

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9iio: ssp_sensors: cleanup codestyle warningdrivers/iio/common/ssp_sensors/ssp_dev.c+1 -13 replies
2/9iio: ssp_sensors: factor out pending list add/remove helper(s)drivers/iio/common/ssp_sensors/ssp_spi.c+33 -256 replies
3/9iio: ssp_sensors: cancel delayed work_refresh on removedrivers/iio/common/ssp_sensors/ssp_dev.c+1 -03 replies
4/9iio: ssp_sensors: factor out mcu enable/disable helper(s)drivers/iio/common/ssp_sensors/ssp_dev.c+14 -41 reply
5/9iio: ssp_sensors: use local struct devicedrivers/iio/common/ssp_sensors/ssp_dev.c+12 -113 replies
6/9iio: ssp_sensors: Drop duplicated wdt timer and work cleanupdrivers/iio/common/ssp_sensors/ssp_dev.c+1 -42 replies
7/9iio: ssp_sensors: convert probe and teardown to devm-managed resourcesdrivers/iio/common/ssp_sensors/ssp_dev.c+65 -520 replies
8/9iio: ssp_sensors: Use dev_err_probedrivers/iio/common/ssp_sensors/ssp_dev.c+14 -243 replies
9/9iio: ssp_sensors: reuse embedded RX buffer for SPI transfersdrivers/iio/common/ssp_sensors/ssp.h drivers/iio/common/ssp_sensors/ssp_spi.c+5 -185 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/9
2/9R-b
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/9] iio: ssp_sensors: improve resource cleanup

From: Sanjay Chitroda <[email protected]>

Hi all,

This patch series improves resource cleanup and error handling in the SSP IIO SPI driver by adopting the recently introduced cleanup helpers.

The changes focus on making probe/remove paths more robust and easier to reason about by reducing manual unwind logic and ensuring that locks and dynamically allocated resources are released consistently across all exit paths.

Key highlights of this series:

- Reuse embedded rx buffer for SPI transfer instead of allocating new DMA memory in interrupt context for write transaction between AP <-> HUB.
- Replace dynamic resource lifetime management with device‑managed (devm_) APIs to simplify cleanup and error paths.
- Refactor common helper API, improving readability and reducing duplicatation.
- Address minor codestyle warnings and use dev_err_probe in probe path.

Changes in v7:
- first 2 checkpatch patches are applied to iio/testing
- address coding type review comment from Andy at multiple places
- add warning fix in ssp_dev driver
- add new change to cancel refresh work
- add helper API for enable/disable MCU
- Following input from Andy add local variable dev to use with APIs
- v6 series: https://lore.kernel.org/all/[email protected]/
Changes in v6:
- 0005: Drop remove() path using devm action with input from David
- 0007: Replace dynamic memory allocation with embedded fixed size struct buffer
- 0004: new: drop duplication in remove()
- 0006: new: Use dev_err_probe in driver probe()
- v5 series: https://lore.kernel.org/all/[email protected]/
Changes in v5:
- Drop usage of guard() helpers to avoid mixing mutex_lock() with
guard()(), based on reviewer feedback.
- 0003: Refactor shared helper API, reducing duplication.
- 0004: Convert resource allocation and teardown to devm_ managed APIs to simplify error handling and probe/remove paths.
- v4 series: https://lore.kernel.org/all/[email protected]/
Changes in v4:
- Update sequence and make checkpatch style fix in base change
- Split WARNING and CHECK change with input of Andy as 0001 and 0002
- 0003: Use guard() instead of scoped_guard()
- 0004: Use preallocated buffer to stash memory allocation
- v3 series: https://lore.kernel.org/all/[email protected]/

No functional behavior changes are intended.

Testing:
- Compiled with W=1
- Build-tested on QEMU x86_64

Feedback and reviews are very welcome.

Thanks,
Sanjay Chitroda

Sanjay Chitroda (9):
iio: ssp_sensors: cleanup codestyle warning
iio: ssp_sensors: factor out pending list add/remove helper(s)
iio: ssp_sensors: cancel delayed work_refresh on remove
iio: ssp_sensors: factor out mcu enable/disable helper(s)
iio: ssp_sensors: use local struct device
iio: ssp_sensors: Drop duplicated wdt timer and work cleanup
iio: ssp_sensors: convert probe and teardown to devm-managed resources
iio: ssp_sensors: Use dev_err_probe
iio: ssp_sensors: reuse embedded RX buffer for SPI transfers

 drivers/iio/common/ssp_sensors/ssp.h     |   3 +
 drivers/iio/common/ssp_sensors/ssp_dev.c | 168 ++++++++++++-----------
 drivers/iio/common/ssp_sensors/ssp_spi.c |  78 +++++------
 3 files changed, 128 insertions(+), 121 deletions(-)

base-commit: eade2b843d9b1f668fc1775f15611bb0a1999cd9

Signature · 1 line
2.34.1