Skip to content

RFC KVM: s390: spring cleanup

Janosch Frank kvm linux-s390 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 27 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10KVM: s390: diag258: Pass absolute address to kvm_is_gpa_in_memslot()arch/s390/kvm/diag.c+1 -13 replies
2/10KVM: s390: Consolidate lpswe variantsarch/s390/kvm/priv.c+21 -255 replies
3/10KVM: s390: Convert shifts to gpa_to_gfn()arch/s390/kvm/interrupt.c arch/s390/kvm/priv.c+3 -33 replies
4/10KVM: s390: kvm_s390_real_to_abs() should return gpa_tarch/s390/kvm/gaccess.h+3 -33 replies
5/10KVM: s390: vsie: Cleanup and fixup of crycb handlingarch/s390/include/asm/kvm_host.h arch/s390/kvm/vsie.c+30 -264 replies
6/10KVM: s390: Rework lowcore access functionsarch/s390/kvm/gaccess.h+22 -102 replies
7/10KVM: s390: Use gpa_t and gva_t in gaccess filesarch/s390/kvm/gaccess.c arch/s390/kvm/gaccess.h+11 -122 replies
8/10KVM: s390: Use gpa_t in priv.carch/s390/kvm/gaccess.h arch/s390/kvm/priv.c+20 -153 replies
9/10KVM: s390: Use gpa_t in pv.carch/s390/kvm/kvm-s390.h arch/s390/kvm/pv.c+10 -103 replies
10/10KVM: s390: Cleanup kvm_s390_store_status_unloadedarch/s390/kvm/kvm-s390.c arch/s390/kvm/kvm-s390.h+18 -102 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchChristian BorntraegerChristoph SchlameussClaudio ImbrendaAnthony KrowiakHendrik Brueckner
1/10R-b R-b R-b
2/10R-b A-b
3/10A-b R-b R-b
4/10A-b R-b R-b
5/10R-b R-b R-b
6/10A-b
7/10R-b R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [RFC 00/10] KVM: s390: spring cleanup

When looking into the new gmap code I also had a look into our handling of addresses as a whole. I've found that we have a lot of unsigned long variables which could be gpa_t or gva_t. There's code where we could use provided functions for calculations like gfn shifting and in general we have a lot of magic constants left which could be defined constants. Some of these contants are already in our code base anyway...

This series tries to clean up some of these problems.
I have more commits that also introduce new types for real and logical addresses but these have to wait until I see a real benefit.

Janosch Frank (10):
KVM: s390: diag258: Pass absolute address to kvm_is_gpa_in_memslot()
KVM: s390: Consolidate lpswe variants
KVM: s390: Convert shifts to gpa_to_gfn()
KVM: s390: kvm_s390_real_to_abs() should return gpa_t
KVM: s390: vsie: Cleanup and fixup of crycb handling
KVM: s390: Rework lowcore access functions
KVM: s390: Use gpa_t and gva_t in gaccess files
KVM: s390: Use gpa_t in priv.c
KVM: s390: Use gpa_t in pv.c
KVM: s390: Cleanup kvm_s390_store_status_unloaded

 arch/s390/include/asm/kvm_host.h |  6 +++
 arch/s390/kvm/diag.c             |  2 +-
 arch/s390/kvm/gaccess.c          | 20 ++++-----
 arch/s390/kvm/gaccess.h          | 49 ++++++++++++++-------
 arch/s390/kvm/interrupt.c        |  4 +-
 arch/s390/kvm/kvm-s390.c         | 24 +++++++----
 arch/s390/kvm/kvm-s390.h         | 12 +++---
 arch/s390/kvm/priv.c             | 73 +++++++++++++++-----------------
 arch/s390/kvm/pv.c               | 12 +++---
 arch/s390/kvm/vsie.c             | 50 +++++++++++-----------
 10 files changed, 138 insertions(+), 114 deletions(-)
Signature · 1 line
2.51.0