Skip to content

ASoC: tegra: Add error logging for probe and callback failures

Sheetal linux-sound linux-tegra lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyIn review
  2. v314 patches 7 repliesSuperseded
  3. v21 patch 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changes in v4 from the cover letter

- [patch 1] Drop redundant dev_err_probe() on tegra_isomgr_adma_register() since it already logs internally. Drop redundant dev_err() at its call site. Add regmap init dev_err_probe() conversion.
- [patch 2] Drop redundant dev_err_probe() wrapping at PEQ/MBDRC init call sites since the called functions already log. Drop redundant dev_err() at those call sites in ope_probe(). Add regmap init, of_get_child_by_name and of_address_to_resource dev_err_probe() conversions.
- [patch 3] New. Use dev_err_probe() for regmap init failures in ASRC, DSPK, ADX, AHUB, AMX, DMIC, I2S, Mixer, MVC and SFC.
- [patch 4] New. Use dev_err_probe() for clk_set_rate and clk_prepare_enable failures in tegra_asoc_machine probe.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: tegra: Add error logging in tegra210_admaif driversound/soc/tegra/tegra210_admaif.c+11 -130 replies
2/4ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC driverssound/soc/tegra/tegra210_mbdrc.c sound/soc/tegra/tegra210_ope.c sound/soc/tegra/tegra210_peq.c+26 -340 replies
3/4ASoC: tegra: Use dev_err_probe() for regmap init failuressound/soc/tegra/tegra186_asrc.c sound/soc/tegra/tegra186_dspk.c sound/soc/tegra/tegra210_adx.c +7 more+30 -400 replies
4/4ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probesound/soc/tegra/tegra_asoc_machine.c+9 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures

Resend pending v3 patches with fixes and add remaining dev_err_probe() conversions.

Patch 1 replaces v3 patch 03/14 (ADMAIF).
Patch 2 replaces v3 patch 09/14 (OPE/PEQ/MBDRC).
Patch 3 is new - adds regmap init conversions across 10 drivers. Patch 4 is new - adds clock error conversions in tegra_asoc_machine.

Changes since v3:
- [patch 1] Drop redundant dev_err_probe() on tegra_isomgr_adma_register() since it already logs internally. Drop redundant dev_err() at its call site. Add regmap init dev_err_probe() conversion.
- [patch 2] Drop redundant dev_err_probe() wrapping at PEQ/MBDRC init call sites since the called functions already log. Drop redundant dev_err() at those call sites in ope_probe(). Add regmap init, of_get_child_by_name and of_address_to_resource dev_err_probe() conversions.
- [patch 3] New. Use dev_err_probe() for regmap init failures in ASRC, DSPK, ADX, AHUB, AMX, DMIC, I2S, Mixer, MVC and SFC.
- [patch 4] New. Use dev_err_probe() for clk_set_rate and clk_prepare_enable failures in tegra_asoc_machine probe.

Sheetal (4):
ASoC: tegra: Add error logging in tegra210_admaif driver
ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers
ASoC: tegra: Use dev_err_probe() for regmap init failures
ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe

 sound/soc/tegra/tegra186_asrc.c         |  7 +++----
 sound/soc/tegra/tegra186_dspk.c         |  7 +++----
 sound/soc/tegra/tegra210_admaif.c       | 24 +++++++++++-------------
 sound/soc/tegra/tegra210_adx.c          |  7 +++----
 sound/soc/tegra/tegra210_ahub.c         |  7 +++----
 sound/soc/tegra/tegra210_amx.c          |  7 +++----
 sound/soc/tegra/tegra210_dmic.c         |  7 +++----
 sound/soc/tegra/tegra210_i2s.c          |  7 +++----
 sound/soc/tegra/tegra210_mbdrc.c        | 19 ++++++++++---------
 sound/soc/tegra/tegra210_mixer.c        |  7 +++----
 sound/soc/tegra/tegra210_mvc.c          |  7 +++----
 sound/soc/tegra/tegra210_ope.c          | 26 ++++++++++----------------
 sound/soc/tegra/tegra210_peq.c          | 19 ++++++++++---------
 sound/soc/tegra/tegra210_sfc.c          |  7 +++----
 sound/soc/tegra/tegra_asoc_machine.c    | 21 ++++++++++-----------
 15 files changed, 82 insertions(+), 99 deletions(-)
Signature · 1 line
2.17.1