Skip to content

KVM: s390: More memory management fixes

Claudio Imbrenda kvm linux-s390 lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 1 replyIn review
  2. v410 patches 1 replySuperseded
  3. v39 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v28 patches16 repliesSuperseded
v17 patches1 replySuperseded

Changes in v5 from the cover letter

* Use gmap_crstep_xchg_atomic() in gmap_handle_minor_crste_fault() instead of dat_crstep_xchg_atomic()
* Check the special bit in the new pte and crste, instead of the old one in _gmap_crstep_xchg_atomic() and in _gmap_ptep_xchg()
* Fix handling of pgste spinlock
* Handle more unshadowing events in _do_shadow_pte() and in _do_shadow_crste()

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10KVM: s390: vsie: Fix dat_split_ste()arch/s390/kvm/dat.c+1 -00 replies
2/10KVM: s390: Remove non-atomic dat_crstep_xchg()arch/s390/kvm/dat.c arch/s390/kvm/dat.h arch/s390/kvm/gaccess.c +2 more+100 -970 replies
3/10KVM: s390: vsie: Fix check for pre-existing shadow mappingarch/s390/kvm/gaccess.c+3 -20 replies
4/10KVM: s390: Fix gmap_link()arch/s390/kvm/dat.c arch/s390/kvm/dat.h arch/s390/kvm/gmap.c+52 -540 replies
5/10KVM: s390: Correctly handle guest mappings without struct pagearch/s390/kvm/dat.h arch/s390/kvm/gmap.c arch/s390/kvm/gmap.h+14 -130 replies
6/10KVM: s390: vsie: Fix nested guest memory shadowingarch/s390/kvm/gaccess.c+15 -60 replies
7/10KVM: s390: vsie: Fix refcount overflow for shadow gmapsarch/s390/kvm/vsie.c+3 -10 replies
8/10KVM: s390: vsie: Fix unshadowing while shadowingarch/s390/kvm/gaccess.c arch/s390/kvm/gmap.c+19 -10 replies
9/10KVM: s390: vsie: Fix guest page tables protectionarch/s390/kvm/gaccess.c+10 -20 replies
10/10KVM: s390: Fix KVM_S390_VCPU_FAULT ioctlarch/s390/kvm/kvm-s390.c+15 -30 replies

Reviews trailers per patch

8 of 10 patches have a Reviewed-by or Acked-by.

PatchChristoph SchlameussSteffen EidenJanosch FrankChristian Borntraeger
1/10R-b R-b R-b
2/10R-b
3/10R-b R-b
4/10R-b
5/10R-b
6/10
7/10R-b R-b
8/10
9/10R-b T-b
10/10R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/10] KVM: s390: More memory management fixes

This series fixes some bugs that have been recently introduced with the big gmap rewrite.

Most of the fixes are related to vSIE (nested guests), although some are more general. The last patch fixes an issue introduced last year.

v4->v5
* Use gmap_crstep_xchg_atomic() in gmap_handle_minor_crste_fault() instead of dat_crstep_xchg_atomic()
* Check the special bit in the new pte and crste, instead of the old one in _gmap_crstep_xchg_atomic() and in _gmap_ptep_xchg()
* Fix handling of pgste spinlock
* Handle more unshadowing events in _do_shadow_pte() and in _do_shadow_crste()

v3->v4
* Reorder the patches a little
* Fix dat_set_pn_crste() to only update its parameter n in case of success
* Fix _do_shadow_pte() and _do_shadow_crste() to return -EOPNOTSUPP when a nested guest would try to write-map guest-read-only memory.
* Move all host page dirtying logic into _gmap_ptep_xchg() and _gmap_crstep_xchg_atomic()
* Make sure gl is not used uninitialized in _gaccess_do_shadow()
* Introduce new s softbit for crstes, analogous to ptes, and use it to determine whether to set a page a dirty

v2->v3
* fix a typo in the code (missin negation in patch 2)
* fix pre-existing alignment issue in _gmap_crstep_xchg_atomic()
* fix nested guest memory shadowing
* properly handle another possible place in _do_shadow_crste() where an unshadowing event could be triggered
* fix _gaccess_do_shadow() to properly handle the case of real-address asces for the nested guest
* fix some typos

v1->v2
* propagate vsie notification bit when splitting a large page
* replace gmap_crstep_xchg() with gmap_crstep_xchg_atomic(); let the callers properly deal with races
* do not attempt to protect guest page table when the nested guest is running in a real address space
* fix return value of KVM_S390_VCPU_FAULT in case of error

Claudio Imbrenda (10):
KVM: s390: vsie: Fix dat_split_ste()
KVM: s390: Remove non-atomic dat_crstep_xchg()
KVM: s390: vsie: Fix check for pre-existing shadow mapping
KVM: s390: Fix gmap_link()
KVM: s390: Correctly handle guest mappings without struct page
KVM: s390: vsie: Fix nested guest memory shadowing
KVM: s390: vsie: Fix refcount overflow for shadow gmaps
KVM: s390: vsie: Fix unshadowing while shadowing
KVM: s390: vsie: Fix guest page tables protection
KVM: s390: Fix KVM_S390_VCPU_FAULT ioctl

 arch/s390/kvm/dat.c      | 100 ++++--------------------
 arch/s390/kvm/dat.h      |  23 +++---
 arch/s390/kvm/gaccess.c  |  71 ++++++++++++-----
 arch/s390/kvm/gmap.c     | 160 ++++++++++++++++++++++++++++-----------
 arch/s390/kvm/gmap.h     |  33 +++++---
 arch/s390/kvm/kvm-s390.c |  18 ++++-
 arch/s390/kvm/vsie.c     |   4 +-
 7 files changed, 231 insertions(+), 178 deletions(-)
Signature · 1 line
2.53.0