Skip to content

Support ACPI and SETAASA device discovery

Akhil R linux-devicetree linux-hwmon linux-i3c linux-tegra lkml sashiko-reviews 7 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest12 patches 3 repliesApplied
  2. v612 patches 15 repliesSuperseded
  3. v512 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v412 patches6 repliesSuperseded
v313 patches5 repliesSuperseded
v213 patches39 repliesSuperseded
v112 patches42 repliesSuperseded

Changes in v7 from the cover letter

* Reject I3C devices with a zero manufacturer ID by validating with I3C_PID_MANUF_ID() instead of the whole PID.
* Keep the static address reserved when a SETAASA device cannot be added, so that it is not assigned to another device during DAA.
* Do not issue RSTDAA when a SETAASA device fails to attach, as no address assignment CCC was sent to it.
* Drop the redundant core clock check in dw_i3c_master_get_core_rate() as probe already fails when the clock is missing without the ACPI skip quirk.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/12dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASADocumentation/devicetree/bindings/i3c/i3c.yaml include/dt-bindings/i3c/i3c.h+35 -50 replies
2/12i3c: master: Use unified device property interfacedrivers/i3c/master.c include/linux/i3c/master.h+46 -360 replies
3/12i3c: master: Support ACPI enumeration of child devicesdrivers/i3c/master.c+143 -80 replies
4/12i3c: master: Add support for devices using SETAASAdrivers/i3c/master.c include/linux/i3c/ccc.h include/linux/i3c/master.h+127 -31 reply
5/12i3c: master: Add support for devices without PIDdrivers/i3c/master.c+41 -111 reply
6/12i3c: master: match I3C device through DT and ACPIdrivers/i3c/master.c+19 -10 replies
7/12i3c: dw-i3c-master: Add SETAASA as supported CCCdrivers/i3c/master/dw-i3c-master.c+2 -00 replies
8/12i3c: dw-i3c-master: Add ACPI core clock frequency quirkdrivers/i3c/master/dw-i3c-master.c+33 -120 replies
9/12i3c: dw-i3c-master: Add ACPI ID for Tegra410drivers/i3c/master/dw-i3c-master.c+4 -30 replies
10/12hwmon: spd5118: Remove 16-bit addressingdrivers/hwmon/spd5118.c+5 -740 replies
11/12hwmon: spd5118: Add I3C supportdrivers/hwmon/Kconfig drivers/hwmon/spd5118.c+61 -40 replies
12/12arm64: defconfig: Enable I3C and SPD5118 hwmonarch/arm64/configs/defconfig+3 -00 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by.

PatchFrank LiRob Herring (Arm)Guenter Roeck
1/12R-b R-b
2/12R-b
3/12R-b
4/12
5/12R-b
6/12R-b
7/12R-b
8/12
9/12R-b
10/12A-b
11/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/12] Support ACPI and SETAASA device discovery

This patch series adds SETAASA device discovery to the I3C subsystem, enabling support for SPD5118 temperature sensors found on DDR5 memory modules. The changes also add ACPI support for all existing DAA methods like SETDASA, SETNEWDA as well as I2C devices on I3C bus.

SPD5118 and similar devices on DDR5 memory modules differ from typical I3C devices in their initialization. They use SETAASA broadcast CCC instead of ENTDAA for address assignment, and per JEDEC specification, are not required to have a Provisioned ID or implement standard device information CCC commands (GETPID, GETDCR, GETBCR).

The series enables describing all I3C and I2C devices on both Device Tree and the ACPI table, using unified device property APIs throughout the I3C core and the Synopsys DesignWare I3C master driver.

Please note that the series modifies drivers across multiple subsystems, like Device Tree bindings, ACPI, I3C and HWMON.

v6->v7:
* Reject I3C devices with a zero manufacturer ID by validating with I3C_PID_MANUF_ID() instead of the whole PID.
* Keep the static address reserved when a SETAASA device cannot be added, so that it is not assigned to another device during DAA.
* Do not issue RSTDAA when a SETAASA device fails to attach, as no address assignment CCC was sent to it.
* Drop the redundant core clock check in dw_i3c_master_get_core_rate() as probe already fails when the clock is missing without the ACPI skip quirk.

v5->v6:
* Do not take an extra fwnode reference when assigning the boardinfo fwnode to a newly registered I3C device.
* Issue SETAASA after SETDASA pre-assignment and before ENTDAA.
* Prefer SETDASA over SETAASA when a device advertises both methods and an explicit dynamic address (assigned-address) is provided.
* Reject PID 0 for non-SETAASA I3C boardinfo entries.
* Drop OF/ACPI uevent modalias emission; keep OF/ACPI matching for SETAASA devices only.
* Resolve DesignWare quirks before core clock acquisition and fail probe early when the clock is missing without the ACPI skip quirk.

v4->v5:
* Free ACPI I2C boardinfo when an ACPI child without an I2C resource is ignored.
* Issue RSTDAA if SETAASA device attach fails after the static address is used as the dynamic address.
* Emit OF and ACPI modaliases for firmware-matched I3C devices.
* Make the DesignWare core clock optional and use "clock-frequency" as the fallback when core_clk is absent.
* Keep DesignWare pclk, reset, and match-data handling on their existing optional paths.

v3->v4:
* Clarify mipi-i3c-static-method bit semantics and assigned-address
* Add I3C_ADDR_METHOD_VENDOR
* Fix fwnode reference handling while converting child property parsing to use unified firmware-node APIs.
* Align ACPI child enumeration with the I2C core for multiple I2cSerialBus resources, ignore ACPI child entries without an I2C resource, and populate I2C modalias information from ACPI.
* Update SETAASA handling to use the static address as the dynamic address, skip device-info retrieval for SETAASA devices, and tolerate M2 for SETHID/SETAASA similarly to ENTDAA.
* Reorder DesignWare I3C clock/reset to include optional clock in the ACPI skip clock/reset quirk.
* Add prints for missing ACPI clock-frequency and SPD5118 I3C device type read failures.
* Fix grammar in comments and commit messages.

v2->v3:
* Fix maximum value and indent bit list for mipi-i3c-static-method.
* Move I3C_ADDR_METHOD_* macros to dt-bindings header.
* Drop ACPICA commit IDs, keep only the Link: tags.
* Revert the change which proceeds to register other devices if SETAASA is not supported so that it aligns with the rest of the driver and to avoid the issues pointed by Sashiko.
* Rework multiple commit messages.

v1->v2:
* Added patch to remove 16-bit addressing support for SPD5118
* Guard ACPI calls with #ifdef CONFIG_ACPI
* Remove CONFIG_OF guard for of_alias_get_highest_id()
* Mask mipi-i3c-static-method in the driver to select only valid values.
* Proceed to register other devices if SETAASA is not supported.
* Update commit message and links in the description of multiple commits.

Akhil R (12):
dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA
i3c: master: Use unified device property interface
i3c: master: Support ACPI enumeration of child devices
i3c: master: Add support for devices using SETAASA
i3c: master: Add support for devices without PID
i3c: master: match I3C device through DT and ACPI
i3c: dw-i3c-master: Add SETAASA as supported CCC
i3c: dw-i3c-master: Add ACPI core clock frequency quirk
i3c: dw-i3c-master: Add ACPI ID for Tegra410
hwmon: spd5118: Remove 16-bit addressing
hwmon: spd5118: Add I3C support
arm64: defconfig: Enable I3C and SPD5118 hwmon

 .../devicetree/bindings/i3c/i3c.yaml          |  36 +-
 arch/arm64/configs/defconfig                  |   3 +
 drivers/hwmon/Kconfig                         |   9 +-
 drivers/hwmon/spd5118.c                       | 119 +++--
 drivers/i3c/master.c                          | 406 +++++++++++++++---
 drivers/i3c/master/dw-i3c-master.c            |  54 ++-
 include/dt-bindings/i3c/i3c.h                 |   4 +
 include/linux/i3c/ccc.h                       |   1 +
 include/linux/i3c/master.h                    |  20 +-
 9 files changed, 507 insertions(+), 145 deletions(-)

base-commit: 6eb8711ece2ce27e52e327a5b7a628ed39b97f45

Signature · 1 line
2.43.0