Skip to content

lsm: Replace security_sb_mount with granular mount hooks

Song Liu linux-fsdevel linux-security-module selinux 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 10 repliesIn review
  2. v58 patches 6 repliesSuperseded
  3. v47 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches9 repliesSuperseded
v27 patches4 repliesSuperseded
v17 patches21 repliesSuperseded

Changes in v6 from the cover letter

1. Move security_mount_bind() and security_mount_move() under LOCK_MOUNT()/LOCK_MOUNT_MAYBE_BENEATH(). (Christian Brauner)
2. Rebase.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8lsm: Add granular mount hooksinclude/linux/lsm_hook_defs.h include/linux/security.h kernel/bpf/bpf_lsm.c +1 more+178 -00 replies
2/8apparmor: Remove redundant MS_MGC_MSK stripping in apparmor_sb_mountsecurity/apparmor/lsm.c+0 -40 replies
3/8apparmor: Convert from sb_mount to granular mount hookssecurity/apparmor/include/mount.h security/apparmor/lsm.c security/apparmor/mount.c+85 -600 replies
4/8selinux: Convert from sb_mount to granular mount hookssecurity/selinux/hooks.c+37 -150 replies
5/8landlock: Convert from sb_mount to granular mount hookssecurity/landlock/fs.c+38 -60 replies
6/8tomoyo: Convert from sb_mount to granular mount hookssecurity/tomoyo/common.h security/tomoyo/mount.c security/tomoyo/tomoyo.c+123 -210 replies
7/8vfs: Replace security_sb_mount/security_move_mount with granular hooksfs/namespace.c+61 -160 replies
8/8lsm: Remove security_sb_mount and security_move_mountinclude/linux/lsm_hook_defs.h include/linux/security.h kernel/bpf/bpf_lsm.c +1 more+0 -600 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by.

PatchStephen SmalleyTetsuo Handa
1/8R-b T-b
2/8
3/8
4/8R-b T-b
5/8
6/8A-b
7/8
8/8R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/8] lsm: Replace security_sb_mount with granular mount hooks

This series replaces the monolithic security_sb_mount() hook with per-operation mount hooks, addressing two main issues:

1. TOCTOU: security_sb_mount() receives dev_name as a string, which LSMs like AppArmor and Tomoyo re-resolve via kern_path(). The new hooks pass pre-resolved struct path pointers where possible (bind mount, move mount), eliminating the double-resolution.

2. Conflation: security_sb_mount() handles bind, new mount, remount, move, propagation changes, and mount reconfiguration through a single hook, requiring LSMs to dispatch on flags internally. The new hooks are called at the operation level with appropriate context.

The new hooks are:

  mount_bind        - bind mount (pre-resolved source path)
  mount_new         - new filesystem mount (with fs_context)
  mount_remount     - filesystem remount (with fs_context)

mount_reconfigure - mount flag reconfiguration (MS_REMOUNT|MS_BIND)
mount_move - move mount (pre-resolved paths)
mount_change_type - propagation type changes

mount_new and mount_remount are called after parse_monolithic_mount_data(), so LSMs have access to the fs_context with parsed mount options. They also receive the original mount(2) flags and data pointer for LSMs (AppArmor, Tomoyo) that need them for policy matching.

The series also replaces security_move_mount() with the new mount_move hook, unifying the old mount(2) MS_MOVE path with the move_mount(2) syscall path.

All existing LSM behaviors are preserved:
AppArmor: same policy matching, TOCTOU fixed for bind/move
SELinux: same permission checks (FILE__MOUNTON, FILESYSTEM__REMOUNT)
Landlock: same deny-all for sandboxed processes
Tomoyo: same policy matching, TOCTOU fixed for bind/move, unused
data_page parameter removed

This work is inspired by earlier discussions:

[1] https://lore.kernel.org/bpf/[email protected]/
[2] https://lore.kernel.org/linux-security-module/[email protected]/

Changes v5 => v6:
1. Move security_mount_bind() and security_mount_move() under LOCK_MOUNT()/LOCK_MOUNT_MAYBE_BENEATH(). (Christian Brauner)
2. Rebase.

v5: https://lore.kernel.org/all/[email protected]/

Changes v4 => v5:
1. Restructure series: add new hooks in security/ first, then convert individual LSMs, then replace old hooks with new hooks in fs/namespace.c (single patch), then remove old hooks. This keeps all fs/namespace.c changes in one patch. (Christian Brauner)
2. Rebase.

v4: https://lore.kernel.org/linux-security-module/[email protected]/

Changes v3 => v4:
1. Move LSM_HOOK_INIT(move_mount, ...) removal from patch 7/7 to each per-LSM conversion patch (3/7, 4/7, 5/7). (Paul Moore)
2. Add kdoc comments to tomoyo mount hook functions and rename tomoyo_move_mount to tomoyo_mount_move in patch 6/7. (Tetsuo Handa)
3. Add Acked-by from Tetsuo Handa to patch 6/7.

v3: https://lore.kernel.org/linux-security-module/[email protected]/

Changes v2 => v3:
1. Rebase.
2. Move security_mount_move() call in vfs_move_mount() from patch 7/7 to patch 1/7. (Paul Moore)

v2: https://lore.kernel.org/linux-security-module/[email protected]/

Changes v1 => v2:
1. Rebase.
2. Add Reviewed-by and Tested-by from Stephen Smalley.

v1: https://lore.kernel.org/linux-security-module/[email protected]/

Song Liu (8):
lsm: Add granular mount hooks
apparmor: Remove redundant MS_MGC_MSK stripping in apparmor_sb_mount
apparmor: Convert from sb_mount to granular mount hooks
selinux: Convert from sb_mount to granular mount hooks
landlock: Convert from sb_mount to granular mount hooks
tomoyo: Convert from sb_mount to granular mount hooks
vfs: Replace security_sb_mount/security_move_mount with granular hooks
lsm: Remove security_sb_mount and security_move_mount

 fs/namespace.c                    |  77 ++++++++++++++----
 include/linux/lsm_hook_defs.h     |  16 +++-
 include/linux/security.h          |  60 +++++++++++---
 kernel/bpf/bpf_lsm.c              |   7 +-
 security/apparmor/include/mount.h |   5 +-
 security/apparmor/lsm.c           | 105 +++++++++++++++++-------
 security/apparmor/mount.c         |  37 ++-------
 security/landlock/fs.c            |  44 ++++++++--
 security/security.c               | 129 +++++++++++++++++++++++-------
 security/selinux/hooks.c          |  52 ++++++++----
 security/tomoyo/common.h          |   2 +-
 security/tomoyo/mount.c           |  31 ++++---
 security/tomoyo/tomoyo.c          | 111 ++++++++++++++++++++++---
 13 files changed, 508 insertions(+), 168 deletions(-)

--
2.53.0-Meta