Skip to content

dpll: zl3073x: add ref-sync pair support

Ivan Vecera linux-devicetree lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 2 repliesSuperseded
  3. v15 patches 16 repliesSuperseded

Changes from the cover letter

v3 - fix ref-sync-sources schema: add items/maxItems constraint for
phandle list without arg cells (Rob Herring)
v2 - added proper reviewed-by tags (requested by Kuba)

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5dpll: zl3073x: clean up esync get/set and use zl3073x_out_is_ndiv()drivers/dpll/zl3073x/dpll.c+20 -440 repliesApplied
2/5dpll: zl3073x: use FIELD_MODIFY() for clear-and-set patternsdrivers/dpll/zl3073x/chan.h drivers/dpll/zl3073x/core.c drivers/dpll/zl3073x/flash.c+8 -150 repliesApplied
3/5dpll: zl3073x: add ref sync and output clock type helpersdrivers/dpll/zl3073x/dpll.c drivers/dpll/zl3073x/out.h drivers/dpll/zl3073x/ref.h +1 more+80 -140 repliesApplied
4/5dt-bindings: dpll: add ref-sync-sources propertyDocumentation/devicetree/bindings/dpll/dpll-pin.yaml Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml+36 -70 repliesApplied
5/5dpll: zl3073x: add ref-sync pair supportdrivers/dpll/zl3073x/dpll.c+206 -10 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPetr OrosPrathosh SatishRob Herring (Arm)
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] dpll: zl3073x: add ref-sync pair support

This series adds Reference-Sync pair support to the ZL3073x DPLL driver. A Ref-Sync pair consists of a clock reference and a low-frequency sync signal (e.g. 1 PPS) where the DPLL locks to the clock reference but phase-aligns to the sync reference.

Patches 1-3 are preparatory cleanups and helper additions:
- Clean up esync get/set callbacks with early returns and use the zl3073x_out_is_ndiv() helper
- Convert open-coded clear-and-set bitfield patterns to FIELD_MODIFY()
- Add ref sync control and output clock type accessor helpers

Patch 4 adds the 'ref-sync-sources' phandle-array property to the dpll-pin device tree binding schema and updates the ZL3073x binding examples.

Patch 5 implements the driver support:
- ref_sync_get/set callbacks with frequency validation
- Automatic sync source exclusion from reference selection
- Device tree based ref-sync pair registration

Tested and verified on Microchip EDS2 (pcb8385) development board.

Changes:
v3 - fix ref-sync-sources schema: add items/maxItems constraint for
phandle list without arg cells (Rob Herring)
v2 - added proper reviewed-by tags (requested by Kuba)

Ivan Vecera (5):
dpll: zl3073x: clean up esync get/set and use zl3073x_out_is_ndiv()
dpll: zl3073x: use FIELD_MODIFY() for clear-and-set patterns
dpll: zl3073x: add ref sync and output clock type helpers
dt-bindings: dpll: add ref-sync-sources property
dpll: zl3073x: add ref-sync pair support

 .../devicetree/bindings/dpll/dpll-pin.yaml    |  13 +
 .../bindings/dpll/microchip,zl30731.yaml      |  30 +-
 drivers/dpll/zl3073x/chan.h                   |  17 +-
 drivers/dpll/zl3073x/core.c                   |   3 +-
 drivers/dpll/zl3073x/dpll.c                   | 295 ++++++++++++++----
 drivers/dpll/zl3073x/flash.c                  |   3 +-
 drivers/dpll/zl3073x/out.h                    |  22 ++
 drivers/dpll/zl3073x/ref.h                    |  46 +++
 drivers/dpll/zl3073x/regs.h                   |   2 +
 9 files changed, 350 insertions(+), 81 deletions(-)
Signature · 1 line
2.52.0