Skip to content

staging: iio: replace sprintf() with sysfs_emit()

Gabriel Rondon linux-iio linux-staging lkml 2 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesApplied
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- ad5933: remove unnecessary (int) cast in ad5933_show_frequency() and use %llu format specifier for unsigned long long (Andy Shevchenko)
- ad9834: simplify wavetype_available show functions by removing intermediate string variable and returning directly (Andy Shevchenko)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3staging: iio: ad7816: use sysfs_emit() in show functionsdrivers/staging/iio/adc/ad7816.c+8 -81 reply
2/3staging: iio: ad5933: use sysfs_emit() in show functionsdrivers/staging/iio/impedance-analyzer/ad5933.c+12 -121 reply
3/3staging: iio: ad9834: use sysfs_emit() and simplify show functionsdrivers/staging/iio/frequency/ad9834.c+6 -141 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging: iio: replace sprintf() with sysfs_emit()

Replace the remaining sprintf() calls with sysfs_emit() in sysfs show functions across three staging IIO drivers: ad7816, ad5933, and ad9834.

sysfs_emit() is the preferred API for sysfs callbacks as it is aware of the PAGE_SIZE buffer limit. Build tested with gcc 13.3.

Changes since v1:
- ad5933: remove unnecessary (int) cast in ad5933_show_frequency() and use %llu format specifier for unsigned long long (Andy Shevchenko)
- ad9834: simplify wavetype_available show functions by removing intermediate string variable and returning directly (Andy Shevchenko)

Gabriel Rondon (3):
staging: iio: ad7816: use sysfs_emit() in show functions
staging: iio: ad5933: use sysfs_emit() in show functions
staging: iio: ad9834: use sysfs_emit() and simplify show functions

 drivers/staging/iio/adc/ad7816.c              | 16 ++++++-------
 drivers/staging/iio/frequency/ad9834.c        | 20 +++++-----------
 .../staging/iio/impedance-analyzer/ad5933.c   | 24 +++++++++----------
 3 files changed, 26 insertions(+), 34 deletions(-)
Signature · 1 line
2.33.0