Skip to content

staging: rtl8723bs: clean up rtw_joinbss_event_prehandle

Jose A. Perez de Azpillaga linux-staging lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v32 patches 3 repliesSuperseded
  3. v22 patches 2 repliesSuperseded

Changes in v4 from the cover letter

- Removed redundant return at the end of the void function.
- Fixed typo in v3 cover letter. ("Rmoed" -> "Removed")
- Picked up Reviewed-by tag from Luka Gejak.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: rtl8723bs: remove dead REJOIN codedrivers/staging/rtl8723bs/core/rtw_mlme.c+2 -260 replies
2/2staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce indentationdrivers/staging/rtl8723bs/core/rtw_mlme.c+70 -650 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLuka GejakDan Carpenter
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] staging: rtl8723bs: clean up rtw_joinbss_event_prehandle

This series cleans up the rtw_joinbss_event_prehandle function in the rtl8723bs staging driver.

The first patch removes dead code guarded by the REJOIN macro, which is never defined in the kernel. This simplifies the function before the subsequent refactor.

The second patch refactors the function using guard clauses and early returns to reduce deep indentation, improving overall readability.

v4:
- Removed redundant return at the end of the void function.
- Fixed typo in v3 cover letter. ("Rmoed" -> "Removed")
- Picked up Reviewed-by tag from Luka Gejak.

v3:
- Removed the 'retry' variable which became dead after REJOIN removal.
- Removed the 'ignore_joinbss_callback' label and use direct returns.
- Preserve the original comment for the join_res <= 0 case.
- Keep the original newline for the netdev_dbg call.
- Moved the 's5' comment after the spin_unlock_bh call to match original placement.

v2:
- Split the original patch into a two-patch series.
- Changed the subject line.
- Removed all REJOIN-related dead code.
- Fixed a typo in the ptarget_sta comment.
- Avoided unnecessary changes.

Jose A. Perez de Azpillaga (2):
staging: rtl8723bs: remove dead REJOIN code
staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce
indentation

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 155 ++++++++++------------
 1 file changed, 68 insertions(+), 87 deletions(-)

--
2.53.0