Skip to content

mm: memory hot(un)plug and SPARSEMEM cleanups

David Hildenbrand (Arm) linux-cxl linux-mm linux-riscv lkml 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20260320-sparsemem_cleanups-ce4ddb2c47de

Versions newest first · linked by author and title

  1. v2 Latest15 patches 6 repliesIn review 14 of 15 applied
  2. v114 patches 38 repliesSuperseded

Changes in v2 from the cover letter

* Added "mm/memory_hotplug: fix possible race in scan_movable_pages()"
* Update the comment above section_deactivate()
* Reordered the flags in sparse_init_one_section()
* Patch description improvements

Patches in v2 14 of 15 applied

#Subject and filesSizeRepliesApplied
1/15mm/memory_hotplug: fix possible race in scan_movable_pages()mm/memory_hotplug.c+8 -33 repliesApplied
2/15mm/memory_hotplug: remove for_each_valid_pfn() usagemm/memory_hotplug.c+2 -20 repliesApplied
3/15mm/sparse: remove WARN_ONs from (online|offline)_mem_sections()mm/sparse.c+2 -150 repliesApplied
4/15mm/Kconfig: make CONFIG_MEMORY_HOTPLUG depend on CONFIG_SPARSEMEM_VMEMMAPmm/Kconfig+1 -10 repliesApplied
5/15mm/memory_hotplug: simplify check_pfn_span()mm/memory_hotplug.c+6 -140 repliesApplied
6/15mm/sparse: remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUGmm/sparse.c+2 -670 repliesApplied
7/15mm/bootmem_info: remove handling for !CONFIG_SPARSEMEM_VMEMMAPmm/bootmem_info.c+0 -370 repliesApplied
8/15mm/bootmem_info: avoid using sparse_decode_mem_map()mm/bootmem_info.c+4 -50 repliesApplied
9/15mm/sparse: remove sparse_decode_mem_map()include/linux/memory_hotplug.h mm/sparse.c+1 -170 repliesApplied
10/15mm/sparse: remove CONFIG_MEMORY_HOTPLUG-specific usemap allocation handlingmm/sparse.c+1 -990 repliesApplied
11/15mm: prepare to move subsection_map_init() to mm/sparse-vmemmap.cinclude/linux/mmzone.h mm/internal.h mm/mm_init.c +1 more+14 -90 repliesApplied
12/15mm/sparse: drop set_section_nid() from sparse_add_section()mm/sparse.c+0 -10 repliesApplied
13/15mm/sparse: move sparse_init_one_section() to internal.hinclude/linux/mmzone.h mm/internal.h mm/sparse.c+23 -251 reply
14/15mm/sparse: move __section_mark_present() to internal.hmm/internal.h mm/sparse.c+9 -80 repliesApplied
15/15mm/sparse: move memory hotplug bits to sparse-vmemmap.cinclude/linux/mmzone.h mm/internal.h mm/sparse-vmemmap.c +1 more+310 -3090 repliesApplied

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchLorenzo Stoakes (Oracle)Mike Rapoport (Microsoft)
1/15R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b
6/15R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b
10/15R-b R-b
11/15R-b R-b
12/15R-b R-b
13/15R-b R-b
14/15R-b R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/15] mm: memory hot(un)plug and SPARSEMEM cleanups

Some cleanups around memory hot(un)plug and SPARSEMEM. In essence, we can limit CONFIG_MEMORY_HOTPLUG to CONFIG_SPARSEMEM_VMEMMAP, remove some dead code, and move all the hotplug bits over to mm/sparse-vmemmap.c.

Some further/related cleanups around other unnecessary code (memory hole handling and complicated usemap allocation).

I have some further sparse.c cleanups lying around, and I'm planning on getting rid of bootmem_info.c entirely.

Cross-compiled on a bunch of machines. Hot(un)plug tested with virtio-mem.

v1 -> v2:
* Added "mm/memory_hotplug: fix possible race in scan_movable_pages()"
* Update the comment above section_deactivate()
* Reordered the flags in sparse_init_one_section()
* Patch description improvements

---
David Hildenbrand (Arm) (15):
mm/memory_hotplug: fix possible race in scan_movable_pages() mm/memory_hotplug: remove for_each_valid_pfn() usage
mm/sparse: remove WARN_ONs from (online|offline)_mem_sections() mm/Kconfig: make CONFIG_MEMORY_HOTPLUG depend on CONFIG_SPARSEMEM_VMEMMAP mm/memory_hotplug: simplify check_pfn_span()
mm/sparse: remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUG mm/bootmem_info: remove handling for !CONFIG_SPARSEMEM_VMEMMAP mm/bootmem_info: avoid using sparse_decode_mem_map()
mm/sparse: remove sparse_decode_mem_map()
mm/sparse: remove CONFIG_MEMORY_HOTPLUG-specific usemap allocation handling
mm: prepare to move subsection_map_init() to mm/sparse-vmemmap.c mm/sparse: drop set_section_nid() from sparse_add_section() mm/sparse: move sparse_init_one_section() to internal.h mm/sparse: move __section_mark_present() to internal.h
mm/sparse: move memory hotplug bits to sparse-vmemmap.c

 include/linux/memory_hotplug.h |   2 -
 include/linux/mmzone.h         |   6 +-
 mm/Kconfig                     |   2 +-
 mm/bootmem_info.c              |  46 +---
 mm/internal.h                  |  47 ++++
 mm/memory_hotplug.c            |  35 ++-
 mm/mm_init.c                   |   2 +-
 mm/sparse-vmemmap.c            | 304 +++++++++++++++++++++++
 mm/sparse.c                    | 539 +----------------------------------------
 9 files changed, 377 insertions(+), 606 deletions(-)

---
base-commit: 3f4f1faa33544d0bd724e32980b6f211c3a9bc7b
change-id: 20260320-sparsemem_cleanups-ce4ddb2c47de

Best regards,

Signature · 1 line
David Hildenbrand (Arm) <[email protected]>