Skip to content

tests/kms_color: Add 10-bit color depth support to gamma test for MediaTek

Jay Liu igt-dev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest1 patch 2 repliesIn review
  2. v41 patch 1 replySuperseded
  3. v31 patch 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/21 patch2 repliesSuperseded
v2 posting 1/20 of 1 patch0 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v5 from the cover letter

- Fix typo in comment: s/Medaitek/MediaTek
- Fix comment formatting: s/0xFFFD0/0xffd0 and add space before "which"
- Simplify depth_10bit initialization: bool depth_10bit = is_mtk_device(data->drm_fd)
- Remove redundant if statement that set depth_10bit
- Improve commit message to explain "why" MediaTek requires these changes:
* Why 10-bit color depth is needed (bit-accurate validation without precision loss)
* Why LUT maximum is set to 0xffd0 instead of 0xffff (hardware mapping behavior)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1tests/kms_color: Add 10-bit color depth support to gamma test for MediaTektests/kms_color.c+23 -62 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchJason-JH Lin
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH i-g-t v5 0/1] tests/kms_color: Add 10-bit color depth support to gamma test for MediaTek

Hi,

This patch introduces support for 10-bit color depth in the kms_color test suite to accommodate MediaTek devices that require a 10-bit pipeline to achieve bit-true results during color verification.

Change in v5:
- Fix typo in comment: s/Medaitek/MediaTek
- Fix comment formatting: s/0xFFFD0/0xffd0 and add space before "which"
- Simplify depth_10bit initialization: bool depth_10bit = is_mtk_device(data->drm_fd)
- Remove redundant if statement that set depth_10bit
- Improve commit message to explain "why" MediaTek requires these changes:
* Why 10-bit color depth is needed (bit-accurate validation without precision loss)
* Why LUT maximum is set to 0xffd0 instead of 0xffff (hardware mapping behavior)

Change in v4:
- Refactor lut_value assignment: declare lut_value variable at the beginning of the function and assign it outside the loop to improve code efficiency.
- Rename is_mtk to depth_10bit: use a more descriptive variable name that reflects the actual purpose (10-bit color depth requirement) rather than device vendor.

Change in v3:
- Fix build error in kms_color.c:the previous patch mistakenly changed primary->crtc to primary->pipe, which caused compilation to fail.

Change in v2:
- Replace the depth_10bit variable with is_mtk to simplify the logic.
- Include a code comment to clarify the justification for using 0xFFD0 as the maximum threshold for the Gamma LUT.

Jay Liu (1):
tests/kms_color: Add 10-bit color depth support to gamma test for
MediaTek

 tests/kms_color.c | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)
Signature · 1 line
2.45.2