Skip to content

mm/damon/sysfs: fix memory leak and NULL dereference issues

SeongJae Park damon linux-mm lkml stable 1 version Applied

Status from this message: [merged mm-hotfixes-stable] mm-damon-sysfs-check-contexts-nr-in-repeat_call_fn.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest3 patches 13 repliesApplied 3/3

Changes in v3 from the cover letter

(https://lore.kernel.org/[email protected])
- Wordsmith second patch commit message.
- Add NULL dereference trigger steps on the commit messages.
- Collect the valid Reviewed-by: from SJ for the second patch.
- Rebased to latest mm-new.

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3mm/damon/sysfs: fix param_ctx leak on damon_sysfs_new_test_ctx() failuremm/damon/sysfs.c+3 -110 repliesApplied
2/3mm/damon/sysfs: check contexts->nr before accessing contexts_arr[0]mm/damon/sysfs.c+3 -00 repliesApplied
3/3mm/damon/sysfs: check contexts->nr in repeat_call_fnmm/damon/sysfs.c+3 -02 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSeongJae Park
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] mm/damon/sysfs: fix memory leak and NULL dereference issues

DAMON_SYSFS can leak memory under allocation failure, and do NULL pointer dereference when a privileged user make wrong sequences of control. Fix those.

Changes from v2
(https://lore.kernel.org/[email protected])
- Wordsmith second patch commit message.
- Add NULL dereference trigger steps on the commit messages.
- Collect the valid Reviewed-by: from SJ for the second patch.
- Rebased to latest mm-new.
Changes from v1
(https://lore.kernel.org/[email protected])
- Check kdamond->contexts->nr from damon_sysfs_handle_cmd()
- Collect Reviewed-by: from SJ for the first and the third patch.

Josh Law (3):
mm/damon/sysfs: fix param_ctx leak on damon_sysfs_new_test_ctx()
failure
mm/damon/sysfs: check contexts->nr before accessing contexts_arr[0] mm/damon/sysfs: check contexts->nr in repeat_call_fn

 mm/damon/sysfs.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

base-commit: 42bc5b563370622d688719aa248a4c861839373a

Signature · 1 line
2.47.3