Skip to content

Add OneXPlayer Configuration HID Driver

Derek J. Clark linux-doc linux-input lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesIn review
  2. v35 patches 0 repliesSuperseded
  3. v25 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches1 replySuperseded

Changes in v4 from the cover letter

- Make all delayed work part of drvdata & ensure they are canceled during remove.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5HID: hid-oxp: Add OneXPlayer configuration driverMAINTAINERS drivers/hid/Kconfig drivers/hid/Makefile +2 more+674 -00 replies
2/5HID: hid-oxp: Add Second Generation RGB Controldrivers/hid/Kconfig drivers/hid/hid-ids.h drivers/hid/hid-oxp.c+155 -00 replies
3/5HID: hid-oxp: Add Second Generation Gamepad Mode Switchdrivers/hid/hid-oxp.c+131 -00 replies
4/5HID: hid-oxp: Add Button Mapping Interfacedrivers/hid/hid-oxp.c+568 -00 replies
5/5HID: hid-oxp: Add Vibration Intensity Attributedrivers/hid/hid-oxp.c+78 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchZhouwang Huang
1/5R-b T-b
2/5R-b T-b
3/5R-b T-b
4/5R-b T-b
5/5R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Add OneXPlayer Configuration HID Driver

Adds an HID driver for OneXPlayer HID configuration devices. There are currently 2 generations of OneXPlayer HID protocol. The first (OneXPlayer F1 series) only provides an RGB control interface over HID. The Second (X1 mini series, G1 series, AOKZOE A1X) also includes a hardware level button mapping interface, vibration intensity settings, and the ability to switch output between xinput and a debug mode that can be used to debug the button mapping. Some devices (G1 Series, APEX) use a hybrid of Gen1 RGB control and Gen 2 controller settings. To ensure there is no conflicts when the driver is loaded, we skip creating the RGB interface for Gen 2 devices if there is a DMI match.

I'll also add a note that Gen 1 devices also have an interface for setting the key map and debug mode, but that is done entirely over a serial TTY device so it is not able to be added to this driver. There are also some "Gen 0" devices (OneXPlayer 2 Series) also use it, but the TTY interface also handles the RGB control so no support is provided by this driver for those interfaces.

---
v4:
- Make all delayed work part of drvdata & ensure they are canceled during remove.

v3: https://lore.kernel.org/linux-input/[email protected]/
- Ensure default button map is properly init during probe.

v2: https://lore.kernel.org/linux-input/[email protected]/
- Add DMI quirks for certain devices that ship with both GEN1 and GEN2
MCU to avoid clashing when initializing the RGB interface.
- Add left & right vibration intensity attributes.
- Add additional mappings for keyboard inputs.
- Add a delayed work trigger to re-apply settings after the MCU
completes initializing after a suspend/resume cycle.

v1: https://lore.kernel.org/linux-input/[email protected]/

Derek J. Clark (5):
HID: hid-oxp: Add OneXPlayer configuration driver
HID: hid-oxp: Add Second Generation RGB Control
HID: hid-oxp: Add Second Generation Gamepad Mode Switch
HID: hid-oxp: Add Button Mapping Interface
HID: hid-oxp: Add Vibration Intensity Attribute

 MAINTAINERS           |    6 +
 drivers/hid/Kconfig   |   13 +
 drivers/hid/Makefile  |    1 +
 drivers/hid/hid-ids.h |    6 +
 drivers/hid/hid-oxp.c | 1580 +++++++++++++++++++++++++++++++++++++++++
 5 files changed, 1606 insertions(+)
 create mode 100644 drivers/hid/hid-oxp.c
Signature · 1 line
2.53.0