Skip to content

Allow AET to use PMT as loadable module

Tony Luck linux-patches lkml 14 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest24 patches 6 repliesIn review
  2. v1325 patches 15 repliesSuperseded
  3. v1225 patches 46 repliesSuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v1123 patches36 repliesSuperseded
v1017 patches23 repliesSuperseded
v912 patches30 repliesSuperseded
v816 patches1 replySuperseded
v714 patches45 repliesSuperseded
v610 patches0 repliesSuperseded
v5 RFC7 patches0 repliesSuperseded
v47 patches32 repliesSuperseded
v37 patches2 repliesSuperseded
v21 patch0 repliesSuperseded
v11 patch0 repliesSuperseded

Patches in v14 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24x86/cpufeatures: Add missing CQM feature dependencyarch/x86/kernel/cpu/cpuid-deps.c+1 -00 replies
2/24x86/resctrl: Check if monitoring features are supportedarch/x86/kernel/cpu/resctrl/core.c+8 -00 replies
3/24x86/resctrl: Centralize monitoring feature enumerationarch/x86/include/asm/resctrl.h arch/x86/kernel/cpu/resctrl/monitor.c+33 -80 replies
4/24x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config()arch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c+28 -180 replies
5/24x86/resctrl: Delete resctrl_cpu_detect()arch/x86/include/asm/processor.h arch/x86/include/asm/resctrl.h arch/x86/kernel/cpu/amd.c +3 more+0 -620 replies
6/24arm,x86,fs/resctrl: Replace architecture capability helpers with generic versionsarch/x86/include/asm/resctrl.h drivers/resctrl/mpam_resctrl.c fs/resctrl/monitor.c +4 more+58 -632 replies
7/24x86/resctrl: Update special case for Intel Haswell enumerationarch/x86/kernel/cpu/resctrl/core.c+5 -30 replies
8/24x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capablearch/x86/include/asm/resctrl.h arch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/monitor.c+3 -180 replies
9/24fs/resctrl: Remove redundant calls to resctrl_mon_capable()fs/resctrl/monitor.c fs/resctrl/rdtgroup.c+2 -22 replies
10/24x86/resctrl: Honor rdt={perf|energy} options to force enable AET eventsarch/x86/kernel/cpu/resctrl/intel_aet.c+1 -11 reply
11/24fs/resctrl: Add interface to disable a monitor eventfs/resctrl/monitor.c include/linux/resctrl.h+51 -00 replies
12/24arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[]arch/x86/kernel/cpu/resctrl/core.c drivers/resctrl/mpam_resctrl.c fs/resctrl/monitor.c +1 more+79 -220 replies
13/24arm,x86,fs/resctrl: Use right size for L3 monitor data structuresarch/x86/kernel/cpu/resctrl/core.c drivers/resctrl/mpam_resctrl.c fs/resctrl/monitor.c +2 more+34 -70 replies
14/24x86,fs/resctrl: Handle systems where AET is the only monitoring featurearch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c +1 more+21 -150 replies
14/24x86,fs/resctrl: Handle systems where AET is the only monitoring featurearch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/intel_aet.c arch/x86/kernel/cpu/resctrl/internal.h +2 more+24 -150 replies
15/24x86/resctrl: Add PMT registration API for AET enumeration callbacksarch/x86/kernel/cpu/resctrl/intel_aet.c include/linux/intel_vsec.h+36 -00 replies
16/24platform/x86/intel/pmt: Register enumeration functions with resctrldrivers/platform/x86/intel/pmt/telemetry.c+14 -10 replies
17/24x86/resctrl: Use registered function pointers for AET enumerationarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/intel_aet.c arch/x86/kernel/cpu/resctrl/internal.h+57 -80 replies
18/24arm,x86,fs/resctrl: Enumerate AET on every resctrl mountarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/intel_aet.c arch/x86/kernel/cpu/resctrl/internal.h +3 more+81 -170 replies
19/24x86/resctrl: Enforce system RMID limit on AETarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/intel_aet.c arch/x86/kernel/cpu/resctrl/internal.h+9 -10 replies
20/24x86/resctrl: Export interface to report telemetry unbind/removearch/x86/kernel/cpu/resctrl/intel_aet.c include/linux/intel_vsec.h+32 -00 replies
20/24x86/resctrl: Export interface to report telemetry unbind/removearch/x86/kernel/cpu/resctrl/intel_aet.c include/linux/intel_vsec.h+80 -90 replies
21/24platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removeddrivers/platform/x86/intel/pmt/telemetry.c+30 -00 replies
22/24x86/resctrl: Require 64-bit x86 for resctrl supportarch/x86/Kconfig+2 -20 replies
23/24x86/resctrl: Simplify Kconfig options for resctrlarch/x86/Kconfig arch/x86/kernel/cpu/resctrl/Makefile arch/x86/kernel/cpu/resctrl/core.c +4 more+21 -480 replies
24/24x86,fs/resctrl: Document telemetry mount timing caveatDocumentation/filesystems/resctrl.rst+7 -10 replies

Reviews trailers per patch

6 of 26 patches have a Reviewed-by or Acked-by.

PatchReinette ChatreTested-by: Chen YuBorislav Petkov (AMD)Ben Horgan
1/24R-b
2/24R-b T-b
3/24
4/24
5/24A-b
6/24R-b A-b
7/24
8/24
9/24R-b
10/24R-b
11/24
12/24
13/24
14/24
14/24
15/24
16/24
17/24
18/24
19/24
20/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v14 thread

Cover letter [PATCH v14 00/24] Allow AET to use PMT as loadable module

Requiring INTEL_PMT_TELEMETRY=y to enable AET is a functional workaround to enable enumeration of Application Energy Telemetry (AET) events, but unacceptable to many users. It results in increased configuration complexity, increased kernel memory footprint and inability to patch problems by unloading a module and loading an updated version.

Add a registration function to the AET code that can be used by INTEL_PMT_TELEMETRY to provide the enumeration functions.

INTEL_PMT_TELEMETRY can be loaded/unloaded independently of resctrl file system mount/unmount. Perform enumeration on every mount and cleanup on every unmount.

Patch series based on TIP tree x86/cache branch current HEAD is:
2c10b3fa5bdf ("fs/resctrl: Ensure default group reports tasks on monitor-only systems")

Previous version (v13) here:

Changes since v13:

[PATCH v14 01/24] x86/cpufeatures: Add missing CQM feature dependency
Add AMD64 manual
s/Linux X86_FEATURE_CQM/X86_FEATURE_CQM/
Complete the trio of context, problem, solution paragraphs by adding the problem statement.

[PATCH v14 02/24] x86/resctrl: Check if monitoring features are supported

Move maintainer note after the "---"
Put the X86_FEATURE_* parenthetical comments back (without "Linux") s/monitoring features/resource monitoring features/g Add Reinette RB tag
Add problem paragraph between context and solution.
Add Chen Yu Tested-by tag

[PATCH v14 03/24] x86/resctrl: Centralize monitoring feature enumeration
Structure commit in context, problem, solution.
Add note that there is still one user of boot_cpu_data.

[PATCH v14 04/24] x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config()
Replaced commit message with Reinette suggestion from v12 review. Two tweaks suggested by AI commit review:
Be more specific that "early" enumeration is simply before resctrl.
s/consumer/reader/g

[PATCH v14 05/24] x86/resctrl: Delete resctrl_cpu_detect()
Split first paragraph into two: context and problem. Don't list all the fields as a regex.

[PATCH v14 06/24] arm,x86,fs/resctrl: Replace architecture capability helpers with generic versions
New Subject: without {alloc,mon}
New commit message in context, problem, solution format
Did not apply Reinette RB tag because of commit message rewrite.

[PATCH v14 07/24] x86/resctrl: Update special case for Intel Haswell enumeration
Updated commit comment in context, problem, solution form.

[PATCH v14 08/24] x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable
New commit message in context, problem, solution format.

[PATCH v14 09/24] fs/resctrl: Remove redundant calls to resctrl_mon_capable()
New commit message confessing that this is fixing a performance problem created by an earlier patch this series.

[PATCH v14 10/24] x86/resctrl: Honor rdt={perf|energy} options to force enable AET events
New commit message. Dropped previous supplied Reinette RB tag.

[PATCH v14 11/24] fs/resctrl: Add interface to disable a monitor event
New commit message. Dropped previous applied Reinette RB tag.

[PATCH v14 12/24] arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[]
New commit message.

[PATCH v14 13/24] arm,x86,fs/resctrl: Use right size for L3 monitor data structures
New commit message.

[PATCH v14 14/24] x86,fs/resctrl: Handle systems where AET is the only monitoring feature
New commit message.

[PATCH v14 15/24] x86/resctrl: Add PMT registration API for AET enumeration callbacks
New commit message.

[PATCH v14 16/24] platform/x86/intel/pmt: Register enumeration functions with resctrl
New commit message.

[PATCH v14 17/24] x86/resctrl: Use registered function pointers for AET enumeration
Updates to resolve locking problems reported by Sashiko in v13.

AET is now going to use a single mutex for both registration and in a later patch for device removal. So change the name from aet_register_lock to just aet_lock.

Reverse locking hierarchy between AET and pmt_telemetry. No longer OK to call into pmt_telemetry to enumerate features with the aet_lock held. Instead, make use of module pinning while holding aet_lock.

New commit message

[PATCH v14 18/24] arm,x86,fs/resctrl: Enumerate AET on every resctrl mount
New commit comment.
aet_register_lock name changed to aet_lock.
Babu: Add commit comment about event_group::force_off

[PATCH v14 19/24] x86/resctrl: Enforce system RMID limit on AET
New commit comment

[PATCH v14 20/24] x86/resctrl: Export interface to report telemetry unbind/remove
Dropped aet_mmio_lock. Now safe to use aet_lock.
New commit message
Add code comment noting that per-package may be over-reaction.

[PATCH v14 21/24] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed
Added commit comment on lock order.
New commit comment.

[PATCH v14 22/24] x86/resctrl: Require 64-bit x86 for resctrl support
New commit message.

[PATCH v14 23/24] x86/resctrl: Simplify Kconfig options for resctrl
New commit message.

[PATCH v14 24/24] x86,fs/resctrl: Document telemetry mount timing caveat
Updated commit message. Include unmount/remount as solution if early mount did not include AET.

Tony Luck (24):
x86/cpufeatures: Add missing CQM feature dependency x86/resctrl: Check if monitoring features are supported x86/resctrl: Centralize monitoring feature enumeration x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config() x86/resctrl: Delete resctrl_cpu_detect() arm,x86,fs/resctrl: Replace architecture capability helpers with
generic versions
x86/resctrl: Update special case for Intel Haswell enumeration x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable fs/resctrl: Remove redundant calls to resctrl_mon_capable() x86/resctrl: Honor rdt={perf|energy} options to force enable AET
events
fs/resctrl: Add interface to disable a monitor event arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[] arm,x86,fs/resctrl: Use right size for L3 monitor data structures x86,fs/resctrl: Handle systems where AET is the only monitoring
feature
x86/resctrl: Add PMT registration API for AET enumeration callbacks platform/x86/intel/pmt: Register enumeration functions with resctrl x86/resctrl: Use registered function pointers for AET enumeration arm,x86,fs/resctrl: Enumerate AET on every resctrl mount x86/resctrl: Enforce system RMID limit on AET x86/resctrl: Export interface to report telemetry unbind/remove platform/x86/intel/pmt: Inform resctrl when MMIO maps are being
removed
x86/resctrl: Require 64-bit x86 for resctrl support x86/resctrl: Simplify Kconfig options for resctrl x86,fs/resctrl: Document telemetry mount timing caveat

 Documentation/filesystems/resctrl.rst      |   8 +-
 include/linux/arm_mpam.h                   |   3 -
 include/linux/intel_vsec.h                 |  14 ++
 include/linux/resctrl.h                    |  84 ++++++++++-
 arch/x86/include/asm/processor.h           |   4 -
 arch/x86/include/asm/resctrl.h             |  24 +---
 arch/x86/kernel/cpu/resctrl/internal.h     |  33 ++---
 arch/x86/kernel/cpu/amd.c                  |   3 -
 arch/x86/kernel/cpu/cpuid-deps.c           |   1 +
 arch/x86/kernel/cpu/hygon.c                |   3 -
 arch/x86/kernel/cpu/intel.c                |   7 -
 arch/x86/kernel/cpu/resctrl/core.c         | 150 +++++++++++---------
 arch/x86/kernel/cpu/resctrl/intel_aet.c    | 156 +++++++++++++++++++--
 arch/x86/kernel/cpu/resctrl/monitor.c      |  78 +++++++----
 drivers/platform/x86/intel/pmt/telemetry.c |  45 +++++-
 drivers/resctrl/mpam_resctrl.c             |  44 +++---
 fs/resctrl/monitor.c                       | 111 +++++++++++----
 fs/resctrl/pseudo_lock.c                   |   6 +-
 fs/resctrl/rdtgroup.c                      |  72 ++++++----
 arch/x86/Kconfig                           |  15 +-
 arch/x86/kernel/cpu/resctrl/Makefile       |   3 +-
 21 files changed, 590 insertions(+), 274 deletions(-)

base-commit: 2c10b3fa5bdf61e344bc522e6c2e00d870ce7ab8

Signature · 1 line
2.56.0