Skip to content

drm/i915/wm: Watermark/SAGV fixes/cleanups/etc

Ville Syrjala intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/i915/wm: Reject SAGV consistently when block_time_us==0drivers/gpu/drm/i915/display/skl_watermark.c+3 -31 reply
2/9drm/i915/wm: Don't compute separate SAGV watermarks for RKLdrivers/gpu/drm/i915/display/intel_display_device.h drivers/gpu/drm/i915/display/skl_watermark.c+9 -71 reply
3/9drm/i915/wm: Consolidate SAGV pipe active/interlace checks to common codedrivers/gpu/drm/i915/display/skl_watermark.c+6 -91 reply
4/9drm/i915/wm: Verify the correct plane DDB entrydrivers/gpu/drm/i915/display/skl_watermark.c+2 -21 reply
5/9drm/i915/wm: Extract skl_wm_level_verify()drivers/gpu/drm/i915/display/skl_watermark.c+36 -581 reply
6/9drm/i915/wm: Extract skl_ddb_entry_verify()drivers/gpu/drm/i915/display/skl_watermark.c+20 -121 reply
7/9drm/i915/wm: Verify 'ddb_y' as well as 'ddb'drivers/gpu/drm/i915/display/skl_watermark.c+4 -01 reply
8/9drm/i915/wm: Reduce copy-pasta in skl_print_plane_wm_changes()drivers/gpu/drm/i915/display/skl_watermark.c+40 -881 reply
9/9drm/i915/wm: Allow SAGV with multiple pipes on pre-icldrivers/gpu/drm/i915/display/intel_bw.c+0 -401 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchVinod Govindapillai
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] drm/i915/wm: Watermark/SAGV fixes/cleanups/etc

From: Ville Syrjälä <[email protected]>

Bunch of work around watermarks and SAGV. A few fixes, some refactoring, and finish off by relaxing the SAGV requirements on pre-icl hardware.

Ville Syrjälä (9):
drm/i915/wm: Reject SAGV consistently when block_time_us==0 drm/i915/wm: Don't compute separate SAGV watermarks for RKL drm/i915/wm: Consolidate SAGV pipe active/interlace checks to common
code
drm/i915/wm: Verify the correct plane DDB entry drm/i915/wm: Extract skl_wm_level_verify()
drm/i915/wm: Extract skl_ddb_entry_verify()
drm/i915/wm: Verify 'ddb_y' as well as 'ddb'
drm/i915/wm: Reduce copy-pasta in skl_print_plane_wm_changes() drm/i915/wm: Allow SAGV with multiple pipes on pre-icl

 drivers/gpu/drm/i915/display/intel_bw.c       |  40 ---
 .../drm/i915/display/intel_display_device.h   |   1 +
 drivers/gpu/drm/i915/display/skl_watermark.c  | 292 +++++++-----------
 3 files changed, 117 insertions(+), 216 deletions(-)
Signature · 1 line
2.52.0