perf addr2line: Rework disable_add2line_warn
Status from this message: Applied to perf-tools-next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 1 replyApplied
- v23 patches 7 repliesSuperseded
- v13 patches 6 repliesSuperseded
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf config: Rename symbol_conf::disable_add2line_warntools/ tools/ tools/ +2 more | +11 | 0 replies | |
| 2/3 | perf config: Make symbol_conf::addr2line_disable_warn configurabletools/ tools/ | +9 | 0 replies | |
| 3/3 | perf addr2line: Remove global variable addr2line_timeout_mstools/ tools/ tools/ +1 more | +6 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Ian Rogers |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] perf addr2line: Rework disable_add2line_warn
Introduce configurable addr2line_disable_warn entry in the .perfconfig file. Clean up addr2line configuration.
V2 --> V3: Added comments from Kim Namhyung
- Use perf_config_bool() to read addr2line-disable-warn value
- Move perfconfig.txt update to proper patch file.
- Fix invalid default value in documentation.
V1 --> V2: Update perf-config documentation.
Patch 1:
Rename disable_add2line_warn to addr2line_disable_warn (with 'r') and start name with prefix addr2line_ to make it consistent with other addr2line_xxx configuration parameters.
Patch 2:
Enable symbol_conf::addr2line_disable_warn set via config file.
Patch 3:
Remove global variable addr2line_timeout_ms and make it a member
Thomas Richter (3):
perf config: Rename symbol_conf::disable_add2line_warn perf config: Make symbol_conf::addr2line_disable_warn configurable perf addr2line: Remove global variable addr2line_timeout_ms
tools/perf/Documentation/perf-config.txt | 6 ++++++ tools/perf/builtin-diff.c | 4 ++-- tools/perf/util/addr2line.c | 20 ++++++++++---------- tools/perf/util/addr2line.h | 2 -- tools/perf/util/block-info.c | 2 +- tools/perf/util/config.c | 6 ++++-- tools/perf/util/libbfd.c | 2 +- tools/perf/util/symbol_conf.h | 3 ++- 8 files changed, 26 insertions(+), 19 deletions(-)
Signature · 1 line
2.53.0