Skip to content

drm/i915: More uncore nukage from display code

Ville Syrjala intel-gfx intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 1 replyIn review
  2. v112 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/i915/qgv: Use intel_de_read() for MTL_MEM_SS_INFO* readsdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_dram.c+5 -50 replies
2/12drm/i915/mchbar: Provide intel_mchbar_read*() abstractiondrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_mchbar.c drivers/gpu/drm/i915/display/intel_mchbar.h +1 more+51 -00 replies
3/12drm/i915/mchbar: Define the end of the MCHBAR mirrordrivers/gpu/drm/i915/intel_mchbar_regs.h+6 -10 replies
4/12drm/i915/mchbar: WARN when accessing non-MCHBAR registers via intel_mchbar_read*()drivers/gpu/drm/i915/display/intel_mchbar.c+56 -00 replies
5/12drm/i915/mchbar: Use intel_mchbar_read() instead of intel_de_read()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display_power.c+5 -30 replies
6/12drm/i915/mchbar: Use intel_mchbar_read*() instead of intel_uncore_read*()drivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_dram.c+19 -310 replies
7/12drm/i915/de: Add intel_de_read16()drivers/gpu/drm/i915/display/intel_de.c drivers/gpu/drm/i915/display/intel_de.h+9 -00 replies
8/12drm/i915/de: s/intel_de_read64_2x32()/intel_de_read64_2x32_volatile()/drivers/gpu/drm/i915/display/intel_de.h drivers/gpu/drm/i915/display/intel_vblank.c drivers/gpu/drm/i915/display/intel_vrr.c+8 -80 replies
9/12drm/i915/de: Add a simple intel_de_read64_2x32()drivers/gpu/drm/i915/display/intel_de.h+12 -00 replies
10/12drm/i915/vrr: Use intel_de_read64_2x32()drivers/gpu/drm/i915/display/intel_vrr.c+2 -40 replies
11/12drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accessesdrivers/gpu/drm/i915/display/intel_mchbar.c+4 -110 replies
12/12drm/i915/rom: Use intel_de for SPI ROM register accessdrivers/gpu/drm/i915/display/intel_rom.c+10 -90 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] drm/i915: More uncore nukage from display code

From: Ville Syrjälä <[email protected]>

Ggt rid of more intel_uncore stuff from the display code:
- new intel_mchbar_read*() abstraction for MCHBAR registers
- some direct replacement of intel_uncore_{read,write}() with intel_de_{read,write}()

v2: Fix bisection on xe (nop intel_uncore_read64())
Deal with review comments

Ville Syrjälä (12):
drm/i915/qgv: Use intel_de_read() for MTL_MEM_SS_INFO* reads drm/i915/mchbar: Provide intel_mchbar_read*() abstraction drm/i915/mchbar: Define the end of the MCHBAR mirror drm/i915/mchbar: WARN when accessing non-MCHBAR registers via
intel_mchbar_read*()
drm/i915/mchbar: Use intel_mchbar_read() instead of intel_de_read() drm/i915/mchbar: Use intel_mchbar_read*() instead of
intel_uncore_read*()
drm/i915/de: Add intel_de_read16()
drm/i915/de: s/intel_de_read64_2x32()/intel_de_read64_2x32_volatile()/ drm/i915/de: Add a simple intel_de_read64_2x32() drm/i915/vrr: Use intel_de_read64_2x32()
drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accesses drm/i915/rom: Use intel_de for SPI ROM register access

 drivers/gpu/drm/i915/Makefile                 |  1 +
 drivers/gpu/drm/i915/display/i9xx_wm.c        | 10 +--
 drivers/gpu/drm/i915/display/intel_bw.c       | 17 ++--
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  5 +-
 drivers/gpu/drm/i915/display/intel_de.c       |  8 ++
 drivers/gpu/drm/i915/display/intel_de.h       | 17 +++-
 .../drm/i915/display/intel_display_power.c    |  3 +-
 drivers/gpu/drm/i915/display/intel_dram.c     | 33 +++-----
 drivers/gpu/drm/i915/display/intel_mchbar.c   | 79 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_mchbar.h   | 19 +++++
 drivers/gpu/drm/i915/display/intel_rom.c      | 19 ++---
 drivers/gpu/drm/i915/display/intel_vblank.c   |  4 +-
 drivers/gpu/drm/i915/display/intel_vrr.c      |  6 +-
 drivers/gpu/drm/i915/intel_mchbar_regs.h      |  7 +-
 drivers/gpu/drm/xe/Makefile                   |  1 +
 15 files changed, 172 insertions(+), 57 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_mchbar.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_mchbar.h
Signature · 1 line
2.52.0