Skip to content

staging: media: atomisp: clean up ia_css_stream_destroy

Jose A. Perez de Azpillaga linux-media linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 1 replyIn review

Changes in v2 from the cover letter

- Split the original patch into a 3-patch series as requested by Dan Carpenter.
- Added a Fixes tag for the loop shadowing bug.
- Separated the extraction from the logical improvements.
- Added clarification that assert() is a wrapper around BUG().

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: media: atomisp: fix loop shadowing in ia_css_stream_destroy()drivers/staging/media/atomisp/pci/sh_css.c+4 -40 replies
2/3staging: media: atomisp: extract ISP2401 cleanup into helper functiondrivers/staging/media/atomisp/pci/sh_css.c+46 -430 replies
3/3staging: media: atomisp: improve cleanup robustness in ia_css_stream_destroy_isp2401()drivers/staging/media/atomisp/pci/sh_css.c+13 -140 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging: media: atomisp: clean up ia_css_stream_destroy

This series fixes a loop shadowing bug and refactors the ISP2401 cleanup logic inside ia_css_stream_destroy().

Changes in v2:
- Split the original patch into a 3-patch series as requested by Dan Carpenter.
- Added a Fixes tag for the loop shadowing bug.
- Separated the extraction from the logical improvements.
- Added clarification that assert() is a wrapper around BUG().

Jose A. Perez de Azpillaga (3):
staging: media: atomisp: fix loop shadowing in ia_css_stream_destroy()
staging: media: atomisp: extract ISP2401 cleanup into helper function
staging: media: atomisp: improve ia_css_stream_destroy_isp2401

 drivers/staging/media/atomisp/pci/sh_css.c | 79 ++++++++++------------
 1 file changed, 37 insertions(+), 42 deletions(-)

--
2.53.0