Skip to content

Support PERF MGMT for RXE

zhenwei pi linux-rdma lkml 7 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 3 repliesApplied
  2. v64 patches 0 repliesSuperseded
  3. v53 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches3 repliesApplied
v33 patches6 repliesSuperseded
v24 patches2 repliesSuperseded
v13 patches3 repliesSuperseded

Changes in v7 from the cover letter

- use 'counters/port_xmit_data' & 'counters/port_rcv_data' instead of 'hw_counters/sent_bytes' & 'hw_counters/rcvd_bytes'

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/4RDMA/rxe: remove rxe_ib_device_get_netdev() and RXE_PORTdrivers/infiniband/sw/rxe/rxe_mcast.c drivers/infiniband/sw/rxe/rxe_net.c drivers/infiniband/sw/rxe/rxe_verbs.c +1 more+7 -140 replies
2/4RDMA/rxe: add SENT/RCVD bytesdrivers/infiniband/sw/rxe/rxe_hw_counters.c drivers/infiniband/sw/rxe/rxe_hw_counters.h drivers/infiniband/sw/rxe/rxe_net.c +2 more+14 -00 replies
3/4RDMA/rxe: support perf mgmt GET methoddrivers/infiniband/sw/rxe/Makefile drivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_mad.c +1 more+109 -00 replies
4/4selftest/rxe: Add selftests for perftools/testing/selftests/rdma/Makefile tools/testing/selftests/rdma/rxe_sent_rcvd_bytes.sh+77 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH v7 0/4] Support PERF MGMT for RXE

v7:
- use 'counters/port_xmit_data' & 'counters/port_rcv_data' instead of 'hw_counters/sent_bytes' & 'hw_counters/rcvd_bytes'

v6:
- return IB_MAD_RESULT_SUCCESS instead of 'IB_MAD_RESULT_SUCCESS | IB_MAD_RESULT_REPLY' on unsupported method
- add a script to verify the sent/rcvd bytes which is wrotten by Yanjun

v5:
- remove patch "RDMA/core: Fix memory free for GID table", it was applied by Jason separately.
- suggested by Yanjun, use 'skb_network_offset' to calculate the length of received packets.

v4:
- drop rxe_ib_device_get_netdev and RXE_PORT, use 1 instead
- avoid UAF to get skb length
- remove one-line wrapper rxe_counter_get, use atomic64_read instead
- fix memory free for GID table, this is a new patch in this series.

v3:
- merge 'RDMA/rxe: use rxe_counter_get' into previous commit
- zero *out* MAD memory
- return success with error status rather than failure to avoid uplayer hang

v2:
- Fix overflow for PMA counter *link_downed_counter*
- Use *rxe_counter_get* instead of *atomic64_read* for hw-counters

v1:
Support PERF MGMT for RXE, add sent/received bytes for RXE counters, also improve coding style.

Zhu Yanjun (1):
selftest/rxe: Add selftests for perf

zhenwei pi (3):
RDMA/rxe: remove rxe_ib_device_get_netdev() and RXE_PORT RDMA/rxe: add SENT/RCVD bytes
RDMA/rxe: support perf mgmt GET method

 drivers/infiniband/sw/rxe/Makefile            |   1 +
 drivers/infiniband/sw/rxe/rxe_hw_counters.c   |   2 +
 drivers/infiniband/sw/rxe/rxe_hw_counters.h   |   2 +
 drivers/infiniband/sw/rxe/rxe_loc.h           |   6 ++
 drivers/infiniband/sw/rxe/rxe_mad.c           | 101 ++++++++++++++++++
 drivers/infiniband/sw/rxe/rxe_mcast.c         |   4 +-
 drivers/infiniband/sw/rxe/rxe_net.c           |   9 +-
 drivers/infiniband/sw/rxe/rxe_recv.c          |   2 +
 drivers/infiniband/sw/rxe/rxe_verbs.c         |   5 +-
 drivers/infiniband/sw/rxe/rxe_verbs.h         |  10 +-
 tools/testing/selftests/rdma/Makefile         |   3 +-
 .../selftests/rdma/rxe_sent_rcvd_bytes.sh     |  75 +++++++++++++
 12 files changed, 206 insertions(+), 14 deletions(-)
 create mode 100644 drivers/infiniband/sw/rxe/rxe_mad.c
 create mode 100755 tools/testing/selftests/rdma/rxe_sent_rcvd_bytes.sh
Signature · 1 line
2.43.0