netem: bug fixes
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest6 patches 8 repliesApplied 6/6
- v75 patches 1 replySuperseded
- v65 patches 0 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 8 patches | 2 replies | Superseded | |
| v4 | 8 patches | 3 replies | Superseded | |
| v3 | 7 patches | 10 replies | Superseded | |
| v2 | 7 patches | 0 replies | Superseded | |
| v1 | 5 patches | 1 reply | Superseded |
Patches in v8 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | net/sched: netem: fix probability gaps in 4-state loss modelnet/ | +4 | 0 replies | Applied |
| 2/6 | net/sched: netem: fix queue limit check to include reordered packetsnet/ | +1 | 1 reply | Applied |
| 3/6 | net/sched: netem: only reseed PRNG when seed is explicitly providednet/ | +6 | 0 replies | Applied |
| 4/6 | net/sched: netem: validate slot configurationnet/ | +29 | 6 replies | Applied |
| 5/6 | net/sched: netem: fix slot delay calculation overflownet/ | +2 | 0 replies | Applied |
| 6/6 | net/sched: netem: check for negative latency and jitternet/ | +22 | 1 reply | Applied |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Simon Horman |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v8 net 0/6] netem: bug fixes
These bugs were found when doing AI-assisted review of sch_netem.c during investigation of the packet duplication recursion problem addressed in Jamal's series.
The fixes cover:
- probability gaps in the 4-state Markov loss model
- queue limit not accounting for reordered packets
- PRNG reseeded on every tc change, breaking reproducibility
- slot configuration not validated (inverted ranges, negative delays, negative limits)
- slot delay arithmetic overflow for ranges above ~2.1 seconds
- negative latency and jitter wrapping to huge time_to_send values via u64 arithmetic
v8 - added check for negative TCA_NETEM_LATENCY64 and TCA_NETEM_JITTER64
- extended slot validation to cover dist_delay, dist_jitter, max_packets and max_bytes
Stephen Hemminger (6):
net/sched: netem: fix probability gaps in 4-state loss model net/sched: netem: fix queue limit check to include reordered packets net/sched: netem: only reseed PRNG when seed is explicitly provided net/sched: netem: validate slot configuration
net/sched: netem: fix slot delay calculation overflow net/sched: netem: check for negative latency and jitter
net/sched/sch_netem.c | 76 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 64 insertions(+), 12 deletions(-)
Signature · 1 line
2.53.0