Skip to content

mm/damon/core: validate damos_quota_goal->nid

SeongJae Park damon linux-mm lkml stable 1 version Applied

Status from this message: [merged mm-stable] mm-damon-core-validate-damos_quota_goal-nid-for-node_memcg_usedfree_bp.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2mm/damon/core: validate damos_quota_goal->nid for node_mem_{used,free}_bpmm/damon/core.c+12 -02 repliesApplied
2/2mm/damon/core: validate damos_quota_goal->nid for node_memcg_{used,free}_bpmm/damon/core.c+7 -02 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] mm/damon/core: validate damos_quota_goal->nid

node_mem[cg]_{used,free}_bp DAMOS quota goals receive the node id. The node id is used for si_meminfo_node() and NODE_DATA() without proper validation. As a result, privileged users can trigger an out of bounds memory access using DAMON_SYSFS. Fix the issues.

The issue was originally reported [1] with a fix by another author. The original author announced [2] that they will stop working including the fix that was still in the review stage. Hence I'm restarting this.

[1] https://lore.kernel.org/[email protected]
[2] https://lore.kernel.org/[email protected]

Changes from RFC
(https://lore.kernel.org/[email protected])
- fix typo in patch 2: s/MEM/MEMCG/.
- rebase to latest mm-new.

SeongJae Park (2):
mm/damon/core: validate damos_quota_goal->nid for

    node_mem_{used,free}_bp

mm/damon/core: validate damos_quota_goal->nid for
node_memcg_{used,free}_bp

 mm/damon/core.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

base-commit: 2f8cc7995d75c89079c55a85fc1d3092ffb7bd59

Signature · 1 line
2.47.3