exfat: unify FAT chain walking helpers
Status from this message: Applied them to #dev.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 3 repliesApplied
- v26 patches 8 repliesSuperseded
- v16 patches 1 replySuperseded
Changes in v3 from the cover letter
- rework exfat_chain_advance
- add error handling in exfat_find_location
- misc tweaks
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | exfat: fix incorrect directory checksum after rename to shorter namefs/ | +1 | 0 replies | |
| 2/6 | exfat: introduce exfat_cluster_walk helperfs/ | +22 | 0 replies | |
| 3/6 | exfat: use exfat_cluster_walk helperfs/ fs/ | +13 | 0 replies | |
| 4/6 | exfat: remove NULL cache pointer case in exfat_ent_getfs/ | +9 | 0 replies | |
| 5/6 | exfat: introduce exfat_chain_advance helperfs/ | +21 | 0 replies | |
| 6/6 | exfat: use exfat_chain_advance helperfs/ fs/ | +25 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | [email protected] | Sungjong Seo | Yuezhang Mo |
|---|---|---|---|
| Series | R-b | R-b | |
| 1/6 | |||
| 2/6 | |||
| 3/6 | |||
| 4/6 | |||
| 5/6 | T-b | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/6] exfat: unify FAT chain walking helpers
From: Chi Zhiling <[email protected]>
This series introduces and uses two new helpers to simplify FAT chain walking logic across the exfat driver:
1. exfat_fat_walk - walks FAT chain by a given step, handling both ALLOC_NO_FAT_CHAIN and ALLOC_FAT_CHAIN modes
2. exfat_chain_advance - walks an exfat_chain structure by a given step, updating both ->dir and ->size fields atomically with proper boundary checking
These helpers replace open-coded cluster walking logic in dir.c, namei.c and inode.c, improving code readability and ensuring consistent error handling for corrupted FAT chains.
Also includes a fix for incorrect directory checksum when renaming a file to a shorter name.
---
Changes in v3:
- rework exfat_chain_advance
- add error handling in exfat_find_location
- misc tweaks
v1:https://lore.kernel.org/linux-fsdevel/[email protected]/ v2:https://lore.kernel.org/linux-fsdevel/[email protected]/
Chi Zhiling (6):
exfat: fix incorrect directory checksum after rename to shorter name
exfat: introduce exfat_cluster_walk helper
exfat: use exfat_cluster_walk helper
exfat: remove NULL cache pointer case in exfat_ent_get
exfat: introduce exfat_chain_advance helper
exfat: use exfat_chain_advance helper
fs/exfat/dir.c | 119 +++++++++++--------------------------------- fs/exfat/exfat_fs.h | 44 +++++++++++++++- fs/exfat/fatent.c | 23 ++++----- fs/exfat/inode.c | 11 +--- fs/exfat/namei.c | 28 +++-------- 5 files changed, 91 insertions(+), 134 deletions(-)
base-commit: 4129a3a2751cba8511cee5d13145223662a8e019
Signature · 1 line
2.43.0