Skip to content

scsi: PR live migration PREEMPT fixes

Stefan Hajnoczi qemu-devel 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3scsi: adjust error_prepend() formattinghw/scsi/scsi-generic.c+2 -20 replies
2/3scsi: always send valid PREEMPT TYPE fieldhw/scsi/scsi-generic.c include/scsi/constants.h+20 -00 replies
3/3scsi: register again after PREEMPT without reservationhw/scsi/scsi-generic.c+10 -03 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchPaolo Bonzini
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] scsi: PR live migration PREEMPT fixes

These patches are for QEMU 11.1 and 11.0-stable because they are not release blockers.

Testing SCSI Persistent Reservation live migration with the Linux LIO iSCSI target exposed two issues:

1. The LIO target interprets the request's TYPE field even though the spec says it should be ignored. This led to PREEMPT commands failing on the LIO target. Work around this by sending a "valid" TYPE field value. I have also contacted the LIO maintainers about improving spec-compliance but QEMU needs to work with existing targets.

2. The LIO target removes all matching registrations, including the I_T nexus that is sending the PREEMPT command, when PREEMPT is used to remove registrations rather than preempt a reservation. This actually appears to comply with the spec, but the hardware target I previously tested against would not remove the calling I_T nexus' registration and therefore QEMU's behavior was wrong. Implement a fix that works regardless of the target.

Stefan Hajnoczi (3):
scsi: adjust error_prepend() formatting
scsi: always send valid PREEMPT TYPE field
scsi: register again after PREEMPT without reservation

 include/scsi/constants.h | 10 ++++++++++
 hw/scsi/scsi-generic.c   | 24 ++++++++++++++++++++++--
 2 files changed, 32 insertions(+), 2 deletions(-)
Signature · 1 line
2.53.0