Engine initialization cleanup
Get series with b4
b4 am [email protected] change-id 20260402-engine-setup-e66851295e18Versions newest first
- v2 Latest10 patches 11 repliesIn review
- v110 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Restrict CCS enablement to Xe_HP and later. The CCS engine has never been enabled on Xe_LP.
- Fix rules on MSI-X enablement to actually use the
xe_rtp_match_has_msix function added. (Shuicheng)
- Drop xe_hw_engine_mmio_write32() prototype from header. (Shuicheng)
- Link to v1: https://lore.kernel.org/r/[email protected]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | drm/xe: Move CCS enablement to engine setup RTPdrivers/ drivers/ drivers/ | +5 | 3 replies | |
| 2/10 | drm/xe/rtp: Add "always true" match functiondrivers/ drivers/ drivers/ | +20 | 0 replies | |
| 3/10 | drm/xe: Stop programming BLIT_CCTL on Xe2 and later platformsdrivers/ | +1 | 1 reply | |
| 4/10 | drm/xe: Move HWSTAM programming to RTPdrivers/ | +5 | 0 replies | |
| 5/10 | drm/xe: Fix name and definition of GFX_MODE registerdrivers/ drivers/ drivers/ +2 more | +6 | 1 reply | |
| 6/10 | drm/xe: Const-ify parameters to xe_device_has_* functionsdrivers/ | +7 | 0 replies | |
| 7/10 | drm/xe: Move GFX_MODE programming to RTPdrivers/ drivers/ drivers/ +2 more | +30 | 1 reply | |
| 8/10 | drm/xe: Drop unnecessary STOP_RING clearingdrivers/ drivers/ drivers/ | +0 | 3 replies | |
| 9/10 | drm/xe: Drop xe_hw_engine_mmio_write32()drivers/ drivers/ | +2 | 1 reply | |
| 10/10 | drm/xe: Mark BCS engines as belonging to the GT forcewake domaindrivers/ | +9 | 0 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Shuicheng Lin | Michal Wajdeczko |
|---|---|---|
| 1/10 | R-b | |
| 2/10 | R-b | |
| 3/10 | R-b | |
| 4/10 | R-b | |
| 5/10 | R-b | |
| 6/10 | R-b | |
| 7/10 | R-b | |
| 8/10 | R-b | |
| 9/10 | R-b | |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/10] Engine initialization cleanup
A lot of our engine initialization code was inherited from i915 and hasn't received too much cleanup since that time. There's also some inconsistencies between the main initialization path used on all platforms, and the vestigial execlist code which isn't actually used but still remains in the driver as dead code for now. Let's clean things up a bit and, where possible, move the required engine programming into the RTP infrastructure so that it will be applied on both initialization paths, and be dumpable/checkable via debugfs.
There's some more restructuring that should happen to more clearly distinguish software state initialization from hardware initialization (and re-initialization on various resets & suspend/resume), but I'll leave that to a follow-up series to prevent this one from getting too complicated.
---
Changes in v2:
- Restrict CCS enablement to Xe_HP and later. The CCS engine has never been enabled on Xe_LP.
- Fix rules on MSI-X enablement to actually use the
xe_rtp_match_has_msix function added. (Shuicheng)
- Drop xe_hw_engine_mmio_write32() prototype from header. (Shuicheng)
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Matt Roper (10):
drm/xe: Move CCS enablement to engine setup RTP drm/xe/rtp: Add "always true" match function
drm/xe: Stop programming BLIT_CCTL on Xe2 and later platforms drm/xe: Move HWSTAM programming to RTP
drm/xe: Fix name and definition of GFX_MODE register drm/xe: Const-ify parameters to xe_device_has_* functions drm/xe: Move GFX_MODE programming to RTP
drm/xe: Drop unnecessary STOP_RING clearing
drm/xe: Drop xe_hw_engine_mmio_write32()
drm/xe: Mark BCS engines as belonging to the GT forcewake domain
drivers/gpu/drm/xe/regs/xe_engine_regs.h | 5 +- drivers/gpu/drm/xe/xe_device.h | 14 +++--- drivers/gpu/drm/xe/xe_execlist.c | 9 ---- drivers/gpu/drm/xe/xe_guc_ads.c | 2 - drivers/gpu/drm/xe/xe_guc_capture.c | 2 +- drivers/gpu/drm/xe/xe_hw_engine.c | 83 +++++++++++++------------------- drivers/gpu/drm/xe/xe_hw_engine.h | 1 - drivers/gpu/drm/xe/xe_lrc.c | 20 -------- drivers/gpu/drm/xe/xe_rtp.c | 15 ++++++ drivers/gpu/drm/xe/xe_rtp.h | 24 +++++++++ 10 files changed, 82 insertions(+), 93 deletions(-)
---
base-commit: 6784fa94a98ae6fceef9c2c171c3e9fb8be6585f
change-id: 20260402-engine-setup-e66851295e18
Best regards,
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation