Skip to content

PCI: tegra: Add Tegra264 support

Thierry Reding linux-arm-kernel linux-devicetree linux-pci linux-tegra lkml 10 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20260402-tegra264-pcie-e30abe23da07

Versions newest first

  1. v10 Latest5 patches 5 repliesApplied
  2. v95 patches 5 repliesSuperseded
  3. v86 patches 10 repliesApplied
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v74 patches9 repliesSuperseded
v64 patches3 repliesSuperseded
v54 patches6 repliesSuperseded
v44 patches4 repliesSuperseded inferred link
v36 patches2 repliesSuperseded inferred link
v25 patches6 repliesSuperseded inferred link
v15 patches19 repliesSuperseded

Changes in v10 from the cover letter

- fix a bandwidth issue when the link down on probe
- Link to v9: https://patch.msgid.link/[email protected]

Patches in v10 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: pci: tegra264: Strictly distinguish C0 from C1-C5Documentation/devicetree/bindings/pci/nvidia,tegra264-pcie.yaml+50 -250 replies
2/5dt-bindings: pci: tegra264: Switch to PCIe root port bindingsDocumentation/devicetree/bindings/pci/nvidia,tegra264-pcie.yaml+32 -82 replies
3/5PCI: tegra: Add Tegra264 supportdrivers/pci/controller/Kconfig drivers/pci/controller/Makefile drivers/pci/controller/pcie-tegra264.c+477 -12 replies
4/5arm64: tegra: Reorder reg and reg-names to match bindingsarch/arm64/boot/dts/nvidia/tegra264.dtsi+24 -240 replies
5/5arm64: tegra: Add PCIe root ports on Tegra264arch/arm64/boot/dts/nvidia/tegra264.dtsi+60 -60 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchRob Herring (Arm)Manivannan Sadhasivam
1/5R-b
2/5
3/5
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 0/5] PCI: tegra: Add Tegra264 support

Hi,

this series adds support for the PCIe controllers found on the Tegra264 SoC. There are six instances, one of which is for internal purposes only and the other five are general purpose.

The first patch tweaks the DT bindings slightly to avoid new DT compiler warnings that slipped through because they are now disabled by default (-Wno-unit_address_vs_reg). The second patch references PCIe root port bindings from the controller bindings, which will allow using the standard WAKE# handling, among other things.

Patch 3 introduces the driver for Tegra264 and patch 4 reorders the reg and reg-names property entries to match the bindings changes from patch
1. Finally, patch 6 adds the PCIe root port nodes required by the DT binding changes in patch 2.

As previously mentioned, this depends on Krishna's PCIe WAKE# interrupt support from here:

    https://lore.kernel.org/all/[email protected]/

Since it is only a runtime dependency, the series can be applied independently, though.

I can pick up patches 4 and 5 into the Tegra tree, but there should be no conflicts, so they should be fine to go in with the rest of the patches. Either way works fine for me.

Thanks,
Thierry

Changes in v10:
- fix a bandwidth issue when the link down on probe
- Link to v9: https://patch.msgid.link/[email protected]

Changes in v9:
- remove suspend/resume support, it doesn't work on Tegra264 yet
- use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
- drop common wait times patch, it was applied already
- rename tegra264_pcie_check_ranges() for clarity
- remove unused header includes
- Link to v8: https://patch.msgid.link/[email protected]

Changes in v8:
- track hotplug support separately from link up state for clarity
- remove unneeded controller deinitialization, done by firmware
- fail probe if the link is down and not hotplug-capable
- select pinctrl sleep state on suspend for symmetry
- switch to PCIe root port bindings (new patches)
- add Reviewed-by and Acked-by tags
- add err_ prefix to goto labels
- use generic WAKE# IRQ support
- Link to v7: https://patch.msgid.link/[email protected]

Changes in v7:
- fix build dependency on PCI_ECAM
- remove pre-silicon support code
- Link to v6: https://patch.msgid.link/[email protected]

Changes in v6:
- address review comments from Sashiko
- rebase onto v7.1-rc1, adjust DT bindings patch accordingly
- Link to v5: https://patch.msgid.link/[email protected]

Changes in v5:
- address review comments for the PCI driver patch
- Link to v4: https://patch.msgid.link/[email protected]

Changes in v4:
- strip out dependencies that are going in through the ARM SoC tree
- revert bindings to oneOf construct so that we don't produce new DTC warnings
- Link to v3: https://patch.msgid.link/[email protected]

Changes in v3:
- integrate PCI standard wait times patch into the series to maintain bisectability
- fix review comments from Mikko
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- fix an issue with sanity-checking disabled BARs
- address review comments
- Link to v1: https://patch.msgid.link/[email protected]

Thanks,
Thierry

---
Thierry Reding (5):
dt-bindings: pci: tegra264: Strictly distinguish C0 from C1-C5
dt-bindings: pci: tegra264: Switch to PCIe root port bindings
PCI: tegra: Add Tegra264 support
arm64: tegra: Reorder reg and reg-names to match bindings
arm64: tegra: Add PCIe root ports on Tegra264

 .../bindings/pci/nvidia,tegra264-pcie.yaml         | 109 +++--
 arch/arm64/boot/dts/nvidia/tegra264.dtsi           | 114 +++--
 drivers/pci/controller/Kconfig                     |  10 +-
 drivers/pci/controller/Makefile                    |   1 +
 drivers/pci/controller/pcie-tegra264.c             | 467 +++++++++++++++++++++
 5 files changed, 640 insertions(+), 61 deletions(-)

---
base-commit: 8306754e0e226390edafb50b0f2c85f7e703077d
change-id: 20260402-tegra264-pcie-e30abe23da07
prerequisite-message-id: [email protected]
prerequisite-patch-id: 0f984d1bf11850bb8f833a26f6945ecf18a9a816

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>