Skip to content

various memory related fixups

[email protected] u-boot 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest4 patches 4 repliesIn review
  2. v93 patches 0 repliesSuperseded
  3. v83 patches 8 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v73 patches5 repliesSuperseded
v63 patches9 repliesSuperseded
v56 patches5 repliesSuperseded
v46 patches6 repliesSuperseded
v36 patches35 repliesSuperseded
v25 patches7 repliesSuperseded
v16 patches13 repliesSuperseded

Changes in v10 from the cover letter

- Fix CI issues

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4boot: image-fdt: free old dtb reservationsboot/image-fdt.c include/image.h+58 -210 replies
2/4test_ut: add a ut_ubman fixture to clean up teststest/py/tests/test_ut.py+21 -51 reply
3/4test: boot: add a fdt reserved region checktest/boot/Makefile test/boot/image_fdt.c test/cmd_ut.c +1 more+89 -10 replies
4/4memory: reserve from start_addr_sp to initial_relocaddrcommon/board_f.c include/asm-generic/global_data.h lib/efi_loader/efi_memory.c +1 more+22 -52 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchIlias ApalodimasSimon Glass
1/4A-b R-b
2/4R-b
3/4A-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCHv10 0/4] various memory related fixups

From: Randolph Sapp <[email protected]>

Nitpicks and fixes from the discovery thread on adding PocketBeagle2 support [1]. This does a lot of general setup required for the device, but these modifications themselves aren't device specific. For those specifically interested in PocketBeagle2 support and don't care about these details, my development branch is public [2].

That first patch may provoke some opinions, but honestly if that warning was still present I wouldn't have spent a week poking holes in both the EFI and LMB allocations systems. Please let me know if there is a specific usecase that it breaks though.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://github.com/StaticRocket/u-boot/tree/feature/pocketbeagle2

v2:
- Remove additional increment and decrement in lmb_free_fdt_regions
- Drop the patch to backfill EFI_CONVENTIONAL_MEMORY
- Adjust the removal loop nitpick patch description
- Change the reserve memory patch to use new end_addr_sp
v3:
- Update lmb flags to use the macro documentation for constants
- Change efi_mem_sort to use list_for_each_entry_safe
v4:
- Fix typos in LMB allocation flags macro documentation
- Rename end_addr_sp to initial_relocaddr
- Keep the map_sysmem dance in the efi u-boot reservation
- Use the active device tree pointed to by gd->fdt_blob to clean up old reservations
v5:
- Keep return value as long in boot_fdt_reserve_region
- Fix formatting in initial_relocaddr patch
v6:
- Drop patches that have been picked up already
- Add board_get_usable_ram_top for the sandbox
- s/boot_fdt_reserve_region/boot_fdt_handle_region/
v7:
- Remove board_get_usable_ram_top for the sandbox
- Reinstate bank hopping logic for U-Boot reserved region
- Update description for gd->initial_relocaddr, make it clear this is also an exclusive value
- Add disclaimer to boot_fdt_add_mem_rsv_regions
- Add static boot_fdt_handle_mem_rsv_regions as a generic walker for the two calls into boot_fdt_add_mem_rsv_regions
- Make boot_fdt_add_mem_rsv_regions fdt pointer const
- Leave the PRAM region out of the reservation. Previous commit messages indicate that this is intended.
- Add a test for boot_fdt_add_mem_rsv_regions
v8:
- Adjust initial_relocaddr doc string
- Convert ref to fixes tag as requested
- Rework test_boot_fdt_add_mem_rsv_regions to mitigate lingering state
v9:
- See patch specific changelogs
v10:
- Fix CI issues

Randolph Sapp (4):
boot: image-fdt: free old dtb reservations
test_ut: add a ut_ubman fixture to clean up tests
test: boot: add a fdt reserved region check
memory: reserve from start_addr_sp to initial_relocaddr

 boot/image-fdt.c                  | 77 ++++++++++++++++++++--------
 common/board_f.c                  |  9 +++-
 include/asm-generic/global_data.h |  9 ++++
 include/image.h                   |  2 +-
 lib/efi_loader/efi_memory.c       |  2 +-
 lib/lmb.c                         |  7 +--
 test/boot/Makefile                |  3 ++
 test/boot/image_fdt.c             | 83 +++++++++++++++++++++++++++++++
 test/cmd_ut.c                     |  2 +
 test/py/tests/test_suite.py       |  2 +-
 test/py/tests/test_ut.py          | 26 ++++++++--
 11 files changed, 190 insertions(+), 32 deletions(-)
 create mode 100644 test/boot/image_fdt.c
Signature · 1 line
2.54.0