Skip to content

Deprecate the qemu-system-i386 binary

Thomas Huth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10target/i386/tcg/sysemu: Move target specific SMM code to separate functionstarget/i386/tcg/system/smm_helper.c+30 -170 replies
2/10target/i386/tcg/sysemu: Allow 32-bit SMM code to be used in the 64-bit binarytarget/i386/tcg/system/smm_helper.c+43 -220 replies
3/10target-info: Add functions for querying whether the target is i386 or x86_64include/qemu/target-info.h target-info.c+42 -00 replies
4/10cpu: Add a way to detect 32-bit mode from argv0include/qemu/target-info.h system/vl.c target-info.c+26 -20 replies
5/10target/i386/cpu: Allow to limit the 64-bit binary to 32-bit mode onlytarget/i386/cpu.c target/i386/cpu.h target/i386/gdbstub.c+14 -230 replies
6/10target/i386: Select a 32-bit/64-bit default CPU during runtimetarget/i386/cpu.h+3 -10 replies
7/10target/i386: Adjust the suffix of the CPU devices to 32-bit/64-bit modetarget/i386/cpu.c target/i386/cpu.h target/i386/host-cpu.c+31 -70 replies
8/10hw/i386/isapc: Adjust the check for valid CPUs in the isapc machinehw/i386/isapc.c target/i386/cpu.c target/i386/cpu.h+12 -90 replies
9/10target/i386: Support migrating from i386 to x86_64 targettarget/i386/cpu.c target/i386/cpu.h target/i386/machine.c+270 -70 replies
10/10docs/about/deprecated: Deprecate the qemu-system-i386 binarydocs/about/deprecated.rst+19 -04 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH for-11.1 00/10] Deprecate the qemu-system-i386 binary

This is a follow-up to my 3-years old patch series here, now with the universal binary initiative in mind:

https://lists.nongnu.org/archive/html/qemu-devel/2023-04/msg04541.html

This patch series allows to run qemu-system-x86_64 in 32-bit-only mode (by renaming or symlinking the binary to "qemu-system-i386" or something similar with a "-i386" suffix). After doing this, qemu-system-x86_64 should be a full superset of qemu-system-i386 (apart from 32-bit KVM support, which however is not required anymore now that we removed support for 32-bit hosts). It is now possible to migrate a guest that has been started with an old "qemu-system-i386" binary to a qemu-system-x86_64 binary that has been renamed with a "-i386" suffix.

Thus we can finally deprecate the qemu-system-i386 binary. This will help to avoid that we have to compile a lot of the x86 stuff twice once we'll finally be able to drop qemu-system-i386 after the deprecation period expired.

Thomas Huth (10):
target/i386/tcg/sysemu: Move target specific SMM code to separate
functions
target/i386/tcg/sysemu: Allow 32-bit SMM code to be used in the 64-bit
binary
target-info: Add functions for querying whether the target is i386 or

    x86_64

cpu: Add a way to detect 32-bit mode from argv0 target/i386/cpu: Allow to limit the 64-bit binary to 32-bit mode only target/i386: Select a 32-bit/64-bit default CPU during runtime target/i386: Adjust the suffix of the CPU devices to 32-bit/64-bit
mode
hw/i386/isapc: Adjust the check for valid CPUs in the isapc machine target/i386: Support migrating from i386 to x86_64 target docs/about/deprecated: Deprecate the qemu-system-i386 binary

 docs/about/deprecated.rst           |  19 +++
 include/qemu/target-info.h          |  28 ++++
 target/i386/cpu.h                   |  68 ++++++---
 hw/i386/isapc.c                     |  18 ++-
 system/vl.c                         |   1 +
 target-info.c                       |  37 +++++
 target/i386/cpu.c                   |  59 +++++---
 target/i386/gdbstub.c               |   2 +-
 target/i386/host-cpu.c              |   6 +-
 target/i386/machine.c               | 222 ++++++++++++++++++++++++++++
 target/i386/tcg/system/smm_helper.c | 104 ++++++++-----
 11 files changed, 483 insertions(+), 81 deletions(-)
Signature · 1 line
2.53.0