iio: light: cm3323: fix and cleanup
Status from this message: Applied this patch, but patch 2 will need to wait for this to make its way
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 3 repliesApplied
- v32 patches 1 replySuperseded
- v22 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 2 replies | Superseded |
Changes in v4 from the cover letter
- Patch 2: Add Reviewed-by tag from Andy Shevchenko
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | iio: light: cm3323: fix reg_conf not being initialized correctlydrivers/ | +2 | 3 replies | |
| 2/2 | iio: light: cm3323: use dev_err_probe() in probe pathdrivers/ | +6 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/2 | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] iio: light: cm3323: fix and cleanup
Series fixes a bug and does a cleanup of the CM3323 color light sensor driver.
Patch 1 fixes data->reg_conf being incorrectly initialized with the return value of the i2c_smbus_write_word_data() instead of the actual register value. Tested with i2c-stub on a Raspberri Pi 3B.
Patch 2 converts dev_err() to dev_err_probe() in the probe path.
Changes in v4:
- Patch 2: Add Reviewed-by tag from Andy Shevchenko
Changes in v3:
- Patch 2: remove extra blank line after cm3323_init() error path in cm3323_probe()
Changes in v2:
- Patch 1: fix typos in commit message
- Patch 2: add struct device *dev to shorten dev_err_probe() calls to one-liners (suggested by Andy Shevchenko)
Aldo Conte (2):
iio: light: cm3323: fix reg_conf not being initialized correctly
iio: light: cm3323: use dev_err_probe() in probe path
drivers/iio/light/cm3323.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
Signature · 1 line
2.53.0