Skip to content

iio: light: cm3323: fix and cleanup

Aldo Conte linux-iio linux-kernel-mentees lkml 4 versions – Applied

Status from this message: Applied this patch, but patch 2 will need to wait for this to make its way

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 3 repliesApplied
  2. v32 patches 1 replySuperseded
  3. v22 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Patch 2: Add Reviewed-by tag from Andy Shevchenko

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2iio: light: cm3323: fix reg_conf not being initialized correctlydrivers/iio/light/cm3323.c+2 -33 replies
2/2iio: light: cm3323: use dev_err_probe() in probe pathdrivers/iio/light/cm3323.c+6 -110 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] iio: light: cm3323: fix and cleanup

Series fixes a bug and does a cleanup of the CM3323 color light sensor driver.

Patch 1 fixes data->reg_conf being incorrectly initialized with the return value of the i2c_smbus_write_word_data() instead of the actual register value. Tested with i2c-stub on a Raspberri Pi 3B.

Patch 2 converts dev_err() to dev_err_probe() in the probe path.

Changes in v4:
- Patch 2: Add Reviewed-by tag from Andy Shevchenko

Changes in v3:
- Patch 2: remove extra blank line after cm3323_init() error path in cm3323_probe()

Changes in v2:
- Patch 1: fix typos in commit message
- Patch 2: add struct device *dev to shorten dev_err_probe() calls to one-liners (suggested by Andy Shevchenko)

Aldo Conte (2):
iio: light: cm3323: fix reg_conf not being initialized correctly
iio: light: cm3323: use dev_err_probe() in probe path

 drivers/iio/light/cm3323.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)
Signature · 1 line
2.53.0