Skip to content

devtools: align trailer checks with kernel convention

Stephen Hemminger dpdk-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 4 patches 0 repliesNew

2 of 4 patches are in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/4devtools: remove blank line requirement between trailersdevtools/check-git-log.sh+17 -160 replies
4/4devtools: demote tag ordering to warningdevtools/check-git-log.sh+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] devtools: align trailer checks with kernel convention

This series makes four incremental changes to check-git-log.sh to align DPDK's commit message trailer handling with the Linux kernel convention.

The motivation came from the recent work in kernel where the same patch needed different trailer formatting for DPDK vs. the kernel. This is unnecessary friction for developers who work across both projects.

Patch 1: Use git's built-in %(trailers) format instead of grepping
the commit body with hand-rolled patterns.

Patch 2: Recognize the kernel trailer tags that DPDK was missing:
Co-developed-by, Closes:, and Link:. Also adds proper format validation for Cc:, Coverity issue:, and Bugzilla ID: tags.

Patch 3: Remove the blank line requirement between relation tags
(Fixes, Cc) and attribution tags (Signed-off-by). All trailers now form a single contiguous block, matching kernel convention and git-interpret-trailers(1) semantics.

Patch 4: Demote tag ordering from error to warning, since the
kernel itself does not enforce strict ordering via tooling.

Stephen Hemminger (4):
devtools: use git trailer parser for tag extraction
devtools: recognize kernel trailer tags
devtools: remove blank line requirement between trailers
devtools: demote tag ordering to warning

 devtools/check-git-log.sh | 50 +++++++++++++++++++++++----------------
 1 file changed, 29 insertions(+), 21 deletions(-)
Signature · 1 line
2.53.0