Skip to content

ALSA: msnd: add suspend/resume support

Cássio Gabriel linux-sound lkml 1 version Applied

Status from this message: Applied both patches to for-next branch. Thanks.

Get series with b4
b4 am [email protected] change-id 20260403-msnd-pm-support-e14d428ca426

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2ALSA: msnd: prepare system sleep supportsound/isa/msnd/msnd.c sound/isa/msnd/msnd.h sound/isa/msnd/msnd_pinnacle_mixer.c+54 -230 replies
2/2ALSA: msnd: add ISA and PnP system sleep callbackssound/isa/msnd/msnd.h sound/isa/msnd/msnd_pinnacle.c+95 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ALSA: msnd: add suspend/resume support

The msnd drivers still have no system-sleep callbacks, and the shared driver file still carries a FIXME for suspend/resume. Probe already depends on rebuilding volatile device state by resetting the DSP, uploading firmware, reinitializing shared memory, restoring mixer settings, and calibrating the ADC. Without matching PM callbacks, the driver has no defined way to recover that state after suspend.

This small series adds the missing suspend/resume support with the minimum scope needed for the current driver.

Patch 1 prepares the driver for PM by:
- accepting SNDRV_PCM_TRIGGER_SUSPEND in the PCM trigger callbacks
- factoring the IRQ enable/disable bodies and adding a helper that can quiesce or rearm the shared IRQ without disturbing irq_ref
- restoring cached master-volume values when mixer state is rebuilt after DSP reinitialization

Patch 2 adds the actual PM callbacks by:
- saving the current capture-source selection and msnd-side MIDI input state
- adding shared card suspend/resume helpers
- wiring those helpers into the ISA driver and the Pinnacle PnP card driver with the current callback signatures

The series intentionally does not add trigger-level PCM resume support. The driver can rebuild hardware state on system resume, but it does not preserve enough runtime queue state to justify advertising full SNDRV_PCM_INFO_RESUME semantics in this change.

---
Cássio Gabriel (2):
ALSA: msnd: prepare system sleep support
ALSA: msnd: add ISA and PnP system sleep callbacks

 sound/isa/msnd/msnd.c                | 72 ++++++++++++++++++---------
 sound/isa/msnd/msnd.h                |  3 ++
 sound/isa/msnd/msnd_pinnacle.c       | 95 +++++++++++++++++++++++++++++++++++-
 sound/isa/msnd/msnd_pinnacle_mixer.c |  4 ++
 4 files changed, 149 insertions(+), 25 deletions(-)

---
base-commit: 9f2a23bd5d30dc0968e56a2b6e5edb58aff1bc6d
change-id: 20260403-msnd-pm-support-e14d428ca426

Best regards,

Signature · 1 line
Cássio Gabriel <[email protected]>