ocfs2: stop BUG_ON crashes in suballoc invalid-dinode paths
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ocfs2: handle invalid dinode in reserve_suballoc_bitsfs/ | +7 | 0 replies | |
| 2/3 | ocfs2: handle invalid dinode in claim_suballoc_bitsfs/ | +7 | 0 replies | |
| 3/3 | ocfs2: handle invalid dinode in _ocfs2_free_suballoc_bitsfs/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] ocfs2: stop BUG_ON crashes in suballoc invalid-dinode paths
commit 10995aa2451a ("ocfs2: Morph the haphazard OCFS2_IS_VALID_DINODE() checks.") converted several OCFS2 dinode corruption checks from graceful error handling to BUG_ON() under the assumption that every caller only sees validated inode buffers.
That assumption does not always hold for JBD-managed buffers. The common inode read path can still hand suballoc code an invalid dinode, which turns crafted filesystem corruption into a kernel panic instead of a normal OCFS2 filesystem error.
This series restores graceful corruption handling at the three independently reachable BUG_ON() sites in fs/ocfs2/suballoc.c:
1. reserve_suballoc_bits()
2. claim_suballoc_bits()
3. _ocfs2_free_suballoc_bits()
The series is split per crash site so each patch fixes one bug. A broader follow-up could harden structural validation for JBD-managed inode reads, but that change touches a much wider read-side contract and is kept out of scope here.
ZhengYuan Huang (3):
ocfs2: handle invalid dinode in reserve_suballoc_bits
ocfs2: handle invalid dinode in claim_suballoc_bits
ocfs2: handle invalid dinode in _ocfs2_free_suballoc_bits
fs/ocfs2/suballoc.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-)
Signature · 1 line
2.43.0