Skip to content

net: pull gso packet headers in core stack

Eric Dumazet netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net: qdisc_pkt_len_segs_init() cleanupnet/core/dev.c+31 -311 replyApplied
2/2net: pull headers in qdisc_pkt_len_segs_init()include/net/dropreason-core.h net/core/dev.c+34 -201 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJoe Damato
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: pull gso packet headers in core stack

Most ndo_start_xmit() methods expects headers of gso packets to be already in skb->head.

net/core/tso.c users are particularly at risk, because tso_build_hdr() does a memcpy(hdr, skb->data, hdr_len);

qdisc_pkt_len_segs_init() already does a dissection of gso packets.

Use pskb_may_pull() instead of skb_header_pointer() to make sure drivers do not have to reimplement this.

First patch is a small cleanup to ease second patch review.

Eric Dumazet (2):
net: qdisc_pkt_len_segs_init() cleanup
net: pull headers in qdisc_pkt_len_segs_init()

 include/net/dropreason-core.h |  3 ++
 net/core/dev.c                | 81 ++++++++++++++++++++---------------
 2 files changed, 49 insertions(+), 35 deletions(-)
Signature · 1 line
2.53.0.1213.gd9a14994de-goog