cdrom: gdrom: fix block I/O and capacity setting
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 0 repliesNew
- v33 patches 1 replySuperseded
- v22 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 9 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | cdrom: gdrom: replace port I/O with MMIO accessorsdrivers/ | +4 | 0 replies | |
| 2/3 | cdrom: gdrom: update gendisk capacity on opendrivers/ | +23 | 0 replies | |
| 3/3 | cdrom: gdrom: verify device access after disc swapdrivers/ | +30 | 0 replies |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Artur Rojek | Adrian McMenamin |
|---|---|---|
| 1/3 | A-b | R-b |
| 2/3 | A-b | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] cdrom: gdrom: fix block I/O and capacity setting
Hi all,
This series fixes a gdrom driver Oops due to bad MMIO register access and fixes the missing updates of the block layer gendisk capacity that prevented ISO9660 mounts from working. It fixes also the case of disc swapping by sending the Test Unit command prior to cdrom_open().
The change was tested on real Sega Dreamcast devices (PAL-E, NTSC-J, NTSC-U) with physical CD-R discs and with GDEMU emulated discs. Before:
Oops on mount and an unusable drive. After: Successfully able to mount and use the inserted medium.
Thanks,
Florian
---v3->v4: Simplified condition in "cdrom: gdrom: update gendisk capacity
on open" according to review feedback. Sort trailers correctly.v2->v3: Added patch "cdrom: gdrom: verify device access after disc swap"
from Artur Rojek to also handle the disc swap case reliably. And added Acked-by, Reviewed-by from v2 to the respective patches. Also handle the GDROM case in gdrom_update_capacity().v1->v2: for "cdrom: gdrom: replace port I/O with MMIO accessors": Don't
use helper functions with io.*_rep(), but writesw() and readsw() local in the respective functions. Improved failure case of gdrom_update_capacity() in gdrom_bdops_open().
v3: https://lore.kernel.org/linux-sh/[email protected]/
v2: https://lore.kernel.org/linux-sh/[email protected]/
v1: https://lore.kernel.org/linux-sh/[email protected]/
Artur Rojek (1):
cdrom: gdrom: verify device access after disc swap
Florian Fuchs (2):
cdrom: gdrom: replace port I/O with MMIO accessors
cdrom: gdrom: update gendisk capacity on open
drivers/cdrom/gdrom.c | 61 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 57 insertions(+), 4 deletions(-)
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
Signature · 1 line
2.43.0