staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 16 repliesIn review
- v35 patches 15 repliesSuperseded
Changes in v4 from the cover letter
- Rebased the patches on top of staging-next
- Remove compilation output from cover letter
- Add changes in each patch version in cover letter
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | staging: rtl8723bs: move constant to right side of test in comparisondrivers/ drivers/ drivers/ +4 more | +18 | 1 reply | |
| 2/5 | staging: rtl8723bs: remove empty if statement blockdrivers/ | +0 | 1 reply | |
| 3/5 | staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()drivers/ | +1 | 1 reply | |
| 4/5 | staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_downdrivers/ | +7 | 1 reply | |
| 5/5 | staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase()drivers/ | +3 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Luka Gejak |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs
This patch series focuses on code cleanup in drivers/staging/rtl8723bs, majorly focusing on fixing checkpatch warnings of constant being on right side of test in comparisons, deletion of empty if block ,use of read_poll_timeout_atomic(), and other code simplifications.
Changes since v3:
- Rebased the patches on top of staging-next
- Remove compilation output from cover letter
- Add changes in each patch version in cover letter
v3 link: https://lore.kernel.org/linux-staging/[email protected]/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
Changes since v2:
- Create patch series, each doing one logical thing
- Use read_poll_timeout_atomic() in _is_fw_read_cmd_down()
- Use single return statement instead of if-else blocks containing return true and return false, in IsFrameTypeCtrl()
- Remove unnecessary changes from the patches
- Convey testing status of the patches
Changes since v1:
- Check for more changes of the type of placing constant on right side of comparison/test in drivers/staging/rtl8723bs/
This patch series is compile tested using the following commands, which include setting the necessary configurations:
1. make defconfig
2. scripts/config --enable CONFIG_STAGING
3. scripts/config --module CONFIG_MMC
4. scripts/config --module CONFIG_RTL8723BS
5. make olddefconfig
6. make -j$(nproc)
7. git rebase -i --exec "make -j$(nproc) M=drivers/staging/rtl8723bs" HEAD~5
However, as Luka reviewed v3 - since these are only style changes, testing is not necessary, so I dropped RFT tag from the patch series.
Prithvi Tambewagh (5):
staging: rtl8723bs: move constant to right side of test in comparison
staging: rtl8723bs: remove empty if statement block
staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()
staging: rtl8723bs: use read_poll_timeout_atomic in
_is_fw_read_cmd_down
staging: rtl8723bs: remove duplicate rate checks in
PHY_GetTxPowerIndexBase()
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 5 +---- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 11 +++++------ drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++----------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- drivers/staging/rtl8723bs/include/wifi.h | 5 +---- 9 files changed, 29 insertions(+), 40 deletions(-)
Signature · 1 line
2.34.1