staging: rtl8723bs: convert xmit init path to errno
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 1 replyIn review
- v46 patches 0 repliesSuperseded
- v31 patch 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 1 patch | 1 reply | Superseded |
Changes in v5 from the cover letter
- Fix trailing whitespace in os_intfs.c
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | staging: rtl8723bs: simplify _rtw_init_xmit_priv control flowdrivers/ | +14 | 0 replies | |
| 2/6 | staging: rtl8723bs: make rtw_alloc_hwxmits staticdrivers/ drivers/ | +40 | 0 replies | |
| 3/6 | staging: rtl8723bs: convert rtw_alloc_hwxmits to return errnodrivers/ | +3 | 0 replies | |
| 4/6 | staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.cdrivers/ drivers/ drivers/ | +13 | 0 replies | |
| 5/6 | staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errnodrivers/ | +6 | 0 replies | |
| 6/6 | staging: rtl8723bs: convert _rtw_init_xmit_priv to return errnodrivers/ drivers/ | +13 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dan Carpenter |
|---|---|
| Series | R-b |
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno
Convert the xmit initialization path to use standard kernel return conventions: 0 on success and negative errno on failure.
This replaces the use of _SUCCESS/_FAIL with proper error codes and improves error propagation.
The changes are split into smaller patches following review feedback from Dan Carpenter, converting one function at a time to make the series easier to review.
v5:
- Fix trailing whitespace in os_intfs.c
v4:
- Split into a series of smaller patches as suggested by Dan Carpenter
- Convert functions step by step to improve reviewability
- Ensure each patch builds independently
v3:
- Rebase onto latest staging-next to resolve conflicts.
v2:
- Rework xmit init path to remove _SUCCESS/_FAIL usage
- Convert allocation helpers to return standard error codes
- Update caller to use direct failure checks
- Address review feedback from Ethan Tidmore
Hungyu Lin (6):
staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow
staging: rtl8723bs: make rtw_alloc_hwxmits static
staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno
staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c
staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno
staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno
drivers/staging/rtl8723bs/core/rtw_xmit.c | 138 +++++++++--------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 - .../staging/rtl8723bs/include/xmit_osdep.h | 1 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 +- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 13 -- 5 files changed, 74 insertions(+), 84 deletions(-)
Signature · 1 line
2.34.1