Skip to content

wifi: mt76: clear cipher state on key removal for WED offload

Joshua Klinesmith linux-wireless stable 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v22 patches 0 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- New patch 1/3: initialize hw_key_idx2 to -1 in mt76_wcid_init() for consistent "no key" sentinel on both key index slots.
- Guard cipher clearing on both hw_key_idx == (u8)-1 AND hw_key_idx2 == (u8)-1, so that GTK rotation (new key installed before old removed) and BIGTK removal while another group key is active do not trigger a premature zero-cipher BSS update.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3wifi: mt76: initialize hw_key_idx2 in mt76_wcid_initdrivers/net/wireless/mediatek/mt76/mac80211.c+1 -00 replies
2/3wifi: mt76: mt7915: clear cipher state on key removal for WED offloaddrivers/net/wireless/mediatek/mt76/mt7915/main.c+13 -00 replies
3/3wifi: mt76: mt7996: clear cipher state on key removal for WED offloaddrivers/net/wireless/mediatek/mt76/mt7996/main.c+20 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH wireless v3 0/3] wifi: mt76: clear cipher state on key removal for WED offload

Clear stale BSS cipher on group key removal so WED-offloaded plaintext traffic is not dropped after switching from encrypted to open/no-encryption mode.

Changes since v2:
- New patch 1/3: initialize hw_key_idx2 to -1 in mt76_wcid_init() for consistent "no key" sentinel on both key index slots.
- Guard cipher clearing on both hw_key_idx == (u8)-1 AND hw_key_idx2 == (u8)-1, so that GTK rotation (new key installed before old removed) and BIGTK removal while another group key is active do not trigger a premature zero-cipher BSS update.

Changes since v1:
- Rebased on current wireless tree.

Joshua Klinesmith (3):
wifi: mt76: initialize hw_key_idx2 in mt76_wcid_init
wifi: mt76: mt7915: clear cipher state on key removal for WED offload
wifi: mt76: mt7996: clear cipher state on key removal for WED offload

 drivers/net/wireless/mediatek/mt76/mac80211.c |  1 +
 .../net/wireless/mediatek/mt76/mt7915/main.c  | 13 +++++++++++
 .../net/wireless/mediatek/mt76/mt7996/main.c  | 23 ++++++++++++++++---
 3 files changed, 34 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0