examples: enable -Wshadow across all examples
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest23 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | examples/ethtool: fix shadow variable warningexamples/ examples/ | +2 | 0 replies | |
| 2/23 | examples/eventdev_pipeline: fix shadow variable warningexamples/ examples/ | +2 | 0 replies | |
| 3/23 | examples/dma: fix shadow variable warningsexamples/ examples/ | +5 | 0 replies | |
| 4/23 | examples/packet_ordering: fix shadow variable warningexamples/ examples/ | +3 | 0 replies | |
| 5/23 | examples/bond: fix shadow variable warningsexamples/ examples/ | +10 | 0 replies | |
| 6/23 | examples/vmdq: fix shadow variable warningexamples/ examples/ | +4 | 0 replies | |
| 7/23 | examples/server_node_efd: fix shadowed variableexamples/ examples/ | +3 | 0 replies | |
| 8/23 | examples/flow_filtering: fix shadowed variablesexamples/ examples/ examples/ | +7 | 0 replies | |
| 9/23 | examples/ipsec-secgw: fix shadowed variablesexamples/ examples/ examples/ +4 more | +34 | 0 replies | |
| 10/23 | examples/ip_pipeline: fix shadow variableexamples/ examples/ | +4 | 0 replies | |
| 11/23 | examples/multi_process: fix shadowed variableexamples/ examples/ | +6 | 0 replies | |
| 12/23 | examples/vm_power_manage: enable shadow warningsexamples/ examples/ | +0 | 0 replies | |
| 13/23 | examples/bbdev_app: enable shadow warningsexamples/ | +0 | 0 replies | |
| 14/23 | examples/ptpclient: fix shadow variable warningsexamples/ examples/ | +69 | 0 replies | |
| 15/23 | examples/vhost: fix shadow warningsexamples/ examples/ | +10 | 0 replies | |
| 16/23 | examples/qos_sched: eliminate shadowed variablesexamples/ examples/ examples/ +1 more | +10 | 0 replies | |
| 17/23 | examples/l2fwd-jobstats: fix shadowed variableexamples/ examples/ | +3 | 0 replies | |
| 18/23 | examples/l2fwd-crypto: remove no shadow flagexamples/ | +0 | 0 replies | |
| 19/23 | examples/l2fwd-event: remove no shadow flagexamples/ | +0 | 0 replies | |
| 20/23 | examples/l2fwd-keepalive: fix shadow variable warningexamples/ examples/ | +1 | 0 replies | |
| 21/23 | examples/l3fwd-graph: remove no shadow flagexamples/ | +0 | 0 replies | |
| 22/23 | examples/l3fwd: fix shadow variable warningsexamples/ examples/ examples/ +4 more | +37 | 0 replies | |
| 23/23 | examples/l3fwd-power: fix shadow variable warningsexamples/ examples/ | +6 | 0 replies |
Reviews trailers per patch
None of the 23 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Bruce Richardson | Chengwen Feng | Radu Nicolau |
|---|---|---|---|
| Series | Series-Acked-by A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b | A-b A-b | A-b |
| 1/23 | |||
| 2/23 | |||
| 3/23 | |||
| 4/23 | |||
| 5/23 | |||
| 6/23 | |||
| 7/23 | |||
| 8/23 | |||
| 9/23 | |||
| 10/23 | |||
| 11/23 | |||
| 12/23 | |||
| 13/23 | |||
| 14/23 | |||
| 15/23 | |||
| 16/23 | |||
| 17/23 | |||
| 18/23 | |||
| 19/23 | |||
| 20/23 | |||
| 21/23 | |||
| 22/23 | |||
| 23/23 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/23] examples: enable -Wshadow across all examples
Several DPDK examples had -Wshadow disabled via no_shadow_cflag in their meson.build files. This series fixes all shadow variable warnings and removes the suppression flag, so that -Wshadow is enabled uniformly across every example.
The fixes fall into three categories:
- Renaming function parameters or local variables that shadow globals (most patches)
- Removing unused function parameters that duplicated globals (dma, bond, flow_filtering, ipsec-secgw, vhost, qos_sched)
- Simply removing no_shadow_cflag where there were no warnings (vm_power_manage, bbdev_app, l2fwd-crypto, l2fwd-event, l3fwd-graph)
All the patches are listed as fixes they are not worth back porting so no Fixes: tag is given.
Stephen Hemminger (23):
examples/ethtool: fix shadow variable warning examples/eventdev_pipeline: fix shadow variable warning examples/dma: fix shadow variable warnings examples/packet_ordering: fix shadow variable warning examples/bond: fix shadow variable warnings examples/vmdq: fix shadow variable warning examples/server_node_efd: fix shadowed variable examples/flow_filtering: fix shadowed variables examples/ipsec-secgw: fix shadowed variables examples/ip_pipeline: fix shadow variable examples/multi_process: fix shadowed variable examples/vm_power_manage: enable shadow warnings examples/bbdev_app: enable shadow warnings examples/ptpclient: fix shadow variable warnings examples/vhost: fix shadow warnings examples/qos_sched: eliminate shadowed variables examples/l2fwd-jobstats: fix shadowed variable examples/l2fwd-crypto: remove no shadow flag examples/l2fwd-event: remove no shadow flag examples/l2fwd-keepalive: fix shadow variable warning examples/l3fwd-graph: remove no shadow flag examples/l3fwd: fix shadow variable warnings examples/l3fwd-power: fix shadow variable warnings
examples/bbdev_app/meson.build | 1 - examples/bond/main.c | 21 ++- examples/bond/meson.build | 1 - examples/dma/dmafwd.c | 10 +- examples/dma/meson.build | 1 - examples/ethtool/ethtool-app/main.c | 4 +- examples/ethtool/meson.build | 1 - examples/eventdev_pipeline/meson.build | 1 - .../eventdev_pipeline/pipeline_worker_tx.c | 4 +- examples/flow_filtering/flow_skeleton.c | 10 +- examples/flow_filtering/main.c | 4 +- examples/flow_filtering/meson.build | 1 - examples/ip_pipeline/cli.c | 9 +- examples/ip_pipeline/meson.build | 1 - examples/ipsec-secgw/ipsec-secgw.c | 3 +- examples/ipsec-secgw/ipsec.c | 3 +- examples/ipsec-secgw/ipsec.h | 1 - examples/ipsec-secgw/ipsec_worker.c | 30 ++-- examples/ipsec-secgw/ipsec_worker.h | 4 +- examples/ipsec-secgw/meson.build | 1 - examples/ipsec-secgw/sa.c | 34 ++--- examples/l2fwd-crypto/meson.build | 1 - examples/l2fwd-event/meson.build | 1 - examples/l2fwd-jobstats/main.c | 6 +- examples/l2fwd-jobstats/meson.build | 1 - examples/l2fwd-keepalive/main.c | 2 +- examples/l2fwd-keepalive/meson.build | 1 - examples/l3fwd-graph/meson.build | 1 - examples/l3fwd-power/main.c | 12 +- examples/l3fwd-power/meson.build | 1 - examples/l3fwd/l3fwd.h | 2 +- examples/l3fwd/l3fwd_em.c | 32 ++-- examples/l3fwd/l3fwd_em_hlm.h | 8 +- examples/l3fwd/l3fwd_lpm.c | 4 +- examples/l3fwd/l3fwd_route.h | 12 +- examples/l3fwd/main.c | 12 +- examples/l3fwd/meson.build | 1 - .../client_server_mp/mp_server/args.c | 12 +- .../client_server_mp/mp_server/meson.build | 1 - examples/packet_ordering/main.c | 6 +- examples/packet_ordering/meson.build | 1 - examples/ptpclient/meson.build | 1 - examples/ptpclient/ptpclient.c | 138 +++++++++--------- examples/qos_sched/cfg_file.c | 12 +- examples/qos_sched/cfg_file.h | 4 +- examples/qos_sched/init.c | 4 +- examples/qos_sched/meson.build | 1 - examples/server_node_efd/efd_server/args.c | 6 +- .../server_node_efd/efd_server/meson.build | 1 - examples/vhost/main.c | 19 +-- examples/vhost/meson.build | 1 - .../vm_power_manager/guest_cli/meson.build | 1 - examples/vm_power_manager/meson.build | 1 - examples/vmdq/main.c | 8 +- examples/vmdq/meson.build | 1 - 55 files changed, 216 insertions(+), 244 deletions(-)
Signature · 1 line
2.53.0